From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753349AbaIHLRI (ORCPT ); Mon, 8 Sep 2014 07:17:08 -0400 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:55197 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753238AbaIHLRH (ORCPT ); Mon, 8 Sep 2014 07:17:07 -0400 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 96.249.243.124 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/+3VSHjOBZnnlIzfwc5doFjC8fkhWkMB0= X-DKIM: OpenDKIM Filter v2.0.1 titan A3BD65DAF10 Date: Mon, 8 Sep 2014 07:16:56 -0400 From: Jason Cooper To: Alexander Gordeev , Thomas Petazzoni , Gregory CLEMENT , Ezequiel Garcia Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , linux-pci@vger.kernel.org Subject: Re: [PATCH v2 2/3] PCI/MSI/Armada-370-xp: Remove arch_msi_check_device() Message-ID: <20140908111656.GC30828@titan.lakedaemon.net> References: <9f3497a0f478f3ee7d4a16b9a4221d4377e5863d.1410078503.git.agordeev@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9f3497a0f478f3ee7d4a16b9a4221d4377e5863d.1410078503.git.agordeev@redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + free-electron's guys. On Sun, Sep 07, 2014 at 08:57:54PM +0200, Alexander Gordeev wrote: > Moving MSI checks from arch_msi_check_device() function to > arch_setup_msi_irqs() function makes code more compact and > allows removing unnecessary hook arch_msi_check_device() > from generic MSI code. > > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: linux-pci@vger.kernel.org > Signed-off-by: Alexander Gordeev > --- > drivers/irqchip/irq-armada-370-xp.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/irqchip/irq-armada-370-xp.c b/drivers/irqchip/irq-armada-370-xp.c > index 574aba0..df60eab 100644 > --- a/drivers/irqchip/irq-armada-370-xp.c > +++ b/drivers/irqchip/irq-armada-370-xp.c > @@ -136,6 +136,10 @@ static int armada_370_xp_setup_msi_irq(struct msi_chip *chip, > struct msi_msg msg; > int virq, hwirq; > > + /* We support MSI, but not MSI-X */ > + if (desc->msi_attrib.is_msix) > + return -EINVAL; > + > hwirq = armada_370_xp_alloc_msi(); > if (hwirq < 0) > return hwirq; > @@ -166,15 +170,6 @@ static void armada_370_xp_teardown_msi_irq(struct msi_chip *chip, > armada_370_xp_free_msi(hwirq); > } > > -static int armada_370_xp_check_msi_device(struct msi_chip *chip, struct pci_dev *dev, > - int nvec, int type) > -{ > - /* We support MSI, but not MSI-X */ > - if (type == PCI_CAP_ID_MSI) > - return 0; > - return -EINVAL; > -} > - > static struct irq_chip armada_370_xp_msi_irq_chip = { > .name = "armada_370_xp_msi_irq", > .irq_enable = unmask_msi_irq, > @@ -213,7 +208,6 @@ static int armada_370_xp_msi_init(struct device_node *node, > > msi_chip->setup_irq = armada_370_xp_setup_msi_irq; > msi_chip->teardown_irq = armada_370_xp_teardown_msi_irq; > - msi_chip->check_device = armada_370_xp_check_msi_device; > msi_chip->of_node = node; > > armada_370_xp_msi_domain = > -- > 1.9.3 >