From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Robert Richter <rric@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Paul Mackerras <paulus@samba.org>,
Stephane Eranian <eranian@google.com>,
Andi Kleen <ak@linux.intel.com>,
kan.liang@intel.com
Subject: Re: [PATCH v4 04/22] perf: Add a capability for AUX_NO_SG pmus to do software double buffering
Date: Mon, 8 Sep 2014 13:31:29 +0200 [thread overview]
Message-ID: <20140908113129.GC6758@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <87oauqv09h.fsf@ashishki-desk.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
On Mon, Sep 08, 2014 at 02:07:22PM +0300, Alexander Shishkin wrote:
> Peter Zijlstra <peterz@infradead.org> writes:
> > In particular this looks like it will allocate double the total amount
> > of pages and 'loose' half of them. There is no corresponding code in the
> > free path to collect them.
>
> This code makes the biggest high order allocation no bigger than half of
> the total requested size. Then, when I allocate the high-order chunks, I
> do a split_page() on them and everywhere else in the code they are
> treated as individual pages, including the free path. So this patch has
> no implication on freeing. Is this your concern?
Ah right. I completely misread the patch. Sorry for the noise.
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-09-08 11:31 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 12:35 [PATCH v4 00/22] perf: Add infrastructure and support for Intel PT Alexander Shishkin
2014-08-20 12:35 ` [PATCH v4 01/22] perf: Add data_{offset,size} to user_page Alexander Shishkin
2014-08-20 12:35 ` [PATCH v4 02/22] perf: Add AUX area to ring buffer for raw data streams Alexander Shishkin
2014-09-08 7:02 ` Peter Zijlstra
2014-09-08 11:16 ` Alexander Shishkin
2014-09-08 11:34 ` Peter Zijlstra
2014-09-08 12:55 ` Alexander Shishkin
2014-09-08 13:12 ` Peter Zijlstra
2014-10-06 9:08 ` Alexander Shishkin
2014-10-06 16:20 ` Peter Zijlstra
2014-10-06 21:52 ` Alexander Shishkin
2014-10-07 15:15 ` Peter Zijlstra
2014-08-20 12:36 ` [PATCH v4 03/22] perf: Support high-order allocations for AUX space Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 04/22] perf: Add a capability for AUX_NO_SG pmus to do software double buffering Alexander Shishkin
2014-09-08 7:17 ` Peter Zijlstra
2014-09-08 11:07 ` Alexander Shishkin
2014-09-08 11:31 ` Peter Zijlstra [this message]
2014-08-20 12:36 ` [PATCH v4 05/22] perf: Add a pmu capability for "exclusive" events Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 06/22] perf: Redirect output from inherited events to parents Alexander Shishkin
2014-09-08 15:26 ` Peter Zijlstra
2014-09-09 9:54 ` Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 07/22] perf: Add api for pmus to write to AUX space Alexander Shishkin
2014-09-08 16:06 ` Peter Zijlstra
2014-09-08 16:18 ` Peter Zijlstra
2014-08-20 12:36 ` [PATCH v4 08/22] perf: Add AUX record Alexander Shishkin
2014-09-09 8:20 ` Peter Zijlstra
2014-08-20 12:36 ` [PATCH v4 09/22] perf: Support overwrite mode for AUX area Alexander Shishkin
2014-09-09 8:33 ` Peter Zijlstra
2014-09-09 8:44 ` Peter Zijlstra
2014-09-09 9:40 ` Alexander Shishkin
2014-09-09 10:55 ` Peter Zijlstra
2014-09-09 11:53 ` Alexander Shishkin
2014-09-09 12:43 ` Peter Zijlstra
2014-09-09 13:00 ` Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 10/22] perf: Add wakeup watermark control to " Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 11/22] perf: add ITRACE_START record to indicate that tracing has started Alexander Shishkin
2014-09-09 9:08 ` Peter Zijlstra
2014-09-09 9:33 ` Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 12/22] x86: Add Intel Processor Trace (INTEL_PT) cpu feature detection Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 13/22] x86: perf: Intel PT and LBR/BTS are mutually exclusive Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 14/22] x86: perf: intel_pt: Intel PT PMU driver Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 15/22] x86: perf: intel_bts: Add BTS " Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 16/22] perf: Add rb_{alloc,free}_kernel api Alexander Shishkin
2014-09-09 9:09 ` Peter Zijlstra
2014-08-20 12:36 ` [PATCH v4 17/22] perf: Add a helper to copy AUX data in the kernel Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 18/22] perf: Add a helper for looking up pmus by type Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 19/22] perf: Add infrastructure for using AUX data in perf samples Alexander Shishkin
2014-09-09 9:11 ` Peter Zijlstra
2014-08-20 12:36 ` [PATCH v4 20/22] perf: Allocate ring buffers for inherited per-task kernel events Alexander Shishkin
2014-09-09 9:12 ` Peter Zijlstra
2014-08-20 12:36 ` [PATCH v4 21/22] perf: Allow AUX sampling for multiple events Alexander Shishkin
2014-08-20 12:36 ` [PATCH v4 22/22] perf: Allow sampling of inherited events Alexander Shishkin
2014-08-25 6:21 ` [PATCH v4 00/22] perf: Add infrastructure and support for Intel PT Adrian Hunter
2014-09-01 16:21 ` Peter Zijlstra
2014-09-01 16:30 ` Peter Zijlstra
2014-09-01 17:17 ` Pawel Moll
[not found] ` <CANLsYky0vuwo7MwKbiGXypkLkrX7k6BOEf2uej3-Z3-HZHKd7w@mail.gmail.com>
2014-09-04 8:26 ` Peter Zijlstra
2014-09-05 13:34 ` Mathieu Poirier
2014-09-08 11:55 ` Alexander Shishkin
2014-09-08 13:08 ` Michael Williams
2014-09-08 13:29 ` Al Grant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908113129.GC6758@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rric@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.