From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johan Hovold Subject: Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter Date: Mon, 8 Sep 2014 19:28:39 +0200 Message-ID: <20140908172839.GA21369@localhost> References: <1409930279-1382-1-git-send-email-octavian.purdila@intel.com> <1409930279-1382-3-git-send-email-octavian.purdila@intel.com> <20140908144447.GD9560@localhost> <20140908163058.GF9560@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Octavian Purdila Cc: Johan Hovold , Greg Kroah-Hartman , Linus Walleij , Alexandre Courbot , wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org, Samuel Ortiz , Lee Jones , Arnd Bergmann , Daniel Baluta , Laurentiu Palcu , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lkml , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-gpio@vger.kernel.org On Mon, Sep 08, 2014 at 08:15:07PM +0300, Octavian Purdila wrote: > Just one more question on this subject: is the following allowed: > > int ret, len; > > or should it be: > > int ret; > int len; I try to avoid it, at least unless obviously related such as min/max or x/y. Johan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754637AbaIHRan (ORCPT ); Mon, 8 Sep 2014 13:30:43 -0400 Received: from mail-la0-f47.google.com ([209.85.215.47]:54295 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754443AbaIHRak (ORCPT ); Mon, 8 Sep 2014 13:30:40 -0400 X-Google-Original-Sender: Date: Mon, 8 Sep 2014 19:28:39 +0200 From: Johan Hovold To: Octavian Purdila Cc: Johan Hovold , Greg Kroah-Hartman , Linus Walleij , Alexandre Courbot , wsa@the-dreams.de, Samuel Ortiz , Lee Jones , Arnd Bergmann , Daniel Baluta , Laurentiu Palcu , linux-usb@vger.kernel.org, lkml , linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter Message-ID: <20140908172839.GA21369@localhost> References: <1409930279-1382-1-git-send-email-octavian.purdila@intel.com> <1409930279-1382-3-git-send-email-octavian.purdila@intel.com> <20140908144447.GD9560@localhost> <20140908163058.GF9560@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 08, 2014 at 08:15:07PM +0300, Octavian Purdila wrote: > Just one more question on this subject: is the following allowed: > > int ret, len; > > or should it be: > > int ret; > int len; I try to avoid it, at least unless obviously related such as min/max or x/y. Johan