From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org, pshelar@nicira.com
Subject: Re: [PATCH][net-next] openvswitch: change the data type of error status to atomic_long_t
Date: Tue, 09 Sep 2014 11:47:48 -0700 (PDT) [thread overview]
Message-ID: <20140909.114748.1778878806000997918.davem@davemloft.net> (raw)
In-Reply-To: <1410001571-13338-1-git-send-email-roy.qing.li@gmail.com>
From: roy.qing.li@gmail.com
Date: Sat, 6 Sep 2014 19:06:11 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> Change the date type of error status from u64 to atomic_long_t, and use atomic
> operation, then remove the lock which is used to protect the error status.
>
> The operation of atomic maybe faster than spin lock.
>
> Cc: Pravin Shelar <pshelar@nicira.com>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
I think in the final analysis this is a good change, it shrinks a
datastructure by eliminating a spinlock, and the performance impact
is a non-argument since these are not happening in performance
critical paths.
So I am going to apply this, thanks.
prev parent reply other threads:[~2014-09-09 18:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 11:06 [PATCH][net-next] openvswitch: change the data type of error status to atomic_long_t roy.qing.li
2014-09-07 3:44 ` Pravin Shelar
2014-09-07 9:24 ` Li RongQing
2014-09-07 23:17 ` David Miller
2014-09-08 11:23 ` Li RongQing
2014-09-08 22:21 ` Cong Wang
2014-09-08 22:26 ` Pravin Shelar
2014-09-09 0:29 ` Li RongQing
2014-09-09 18:47 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909.114748.1778878806000997918.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.