From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58640)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XRBXw-00062f-BI
	for qemu-devel@nongnu.org; Mon, 08 Sep 2014 22:52:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XRBXm-0005m2-HB
	for qemu-devel@nongnu.org; Mon, 08 Sep 2014 22:52:44 -0400
Received: from mail-pa0-x22e.google.com ([2607:f8b0:400e:c03::22e]:63435)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XRBXm-0005ko-7E
	for qemu-devel@nongnu.org; Mon, 08 Sep 2014 22:52:34 -0400
Received: by mail-pa0-f46.google.com with SMTP id kq14so1386418pab.33
	for <qemu-devel@nongnu.org>; Mon, 08 Sep 2014 19:52:32 -0700 (PDT)
Date: Tue, 9 Sep 2014 10:52:28 +0800
From: Jun Li <junmuzi@gmail.com>
Message-ID: <20140909025228.GA5336@localhost.localdomain>
References: <1409568798-2292-1-git-send-email-junmuzi@gmail.com>
	<20140905102123.GE4656@noname.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140905102123.GE4656@noname.str.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table
 realization for update_refcount
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: famz@redhat.com, juli@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Fri, 09/05 12:21, Kevin Wolf wrote:
> Am 01.09.2014 um 12:52 hat Jun Li geschrieben:
> > When every item of refcount block is NULL, free refcount block and reset the
> > corresponding item of refcount table with NULL.
> > 
> > Signed-off-by: Jun Li <address@hidden>
> 
> The commit message should also describe why this is a relevant
> improvement for some use case. My gut feeling is that it complicates the
> code for a very minimal gain.

Hi Kevin,
  
  "Add update refcount table realization for update_refcount" is nesseary for
  qcow2 shrinking. I will submit v3 of "qcow2: Patch for shrinking qcow2 disk
  image". When check the code of update_refcount, I find it lacks of this patch.

Best Regards,
Jun Li