From: Kevin Wolf <kwolf@redhat.com>
To: Jun Li <junmuzi@gmail.com>
Cc: famz@redhat.com, juli@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount
Date: Tue, 9 Sep 2014 10:21:54 +0200 [thread overview]
Message-ID: <20140909082154.GC4847@noname.str.redhat.com> (raw)
In-Reply-To: <20140909025228.GA5336@localhost.localdomain>
Am 09.09.2014 um 04:52 hat Jun Li geschrieben:
> On Fri, 09/05 12:21, Kevin Wolf wrote:
> > Am 01.09.2014 um 12:52 hat Jun Li geschrieben:
> > > When every item of refcount block is NULL, free refcount block and reset the
> > > corresponding item of refcount table with NULL.
> > >
> > > Signed-off-by: Jun Li <address@hidden>
> >
> > The commit message should also describe why this is a relevant
> > improvement for some use case. My gut feeling is that it complicates the
> > code for a very minimal gain.
>
> Hi Kevin,
>
> "Add update refcount table realization for update_refcount" is nesseary for
> qcow2 shrinking. I will submit v3 of "qcow2: Patch for shrinking qcow2 disk
> image". When check the code of update_refcount, I find it lacks of this patch.
Why is it necessary? Can't you just leave the refcount blocks allocated?
They shouldn't take a lot of space.
Kevin
next prev parent reply other threads:[~2014-09-09 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 10:52 [Qemu-devel] [PATCH v2] qcow2: add update refcount table realization for update_refcount Jun Li
2014-09-01 11:11 ` Benoît Canet
2014-09-01 16:04 ` Jun Li
2014-09-02 13:38 ` Benoît Canet
2014-09-02 17:12 ` Greg Kurz
2014-09-22 1:45 ` jun muzi
2014-09-05 10:21 ` Kevin Wolf
2014-09-09 2:52 ` Jun Li
2014-09-09 8:21 ` Kevin Wolf [this message]
2014-09-09 14:04 ` Jun Li
2014-09-05 15:33 ` Stefan Hajnoczi
2014-09-13 15:53 ` Jun Li
2014-09-15 9:27 ` Stefan Hajnoczi
2014-09-05 15:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140909082154.GC4847@noname.str.redhat.com \
--to=kwolf@redhat.com \
--cc=famz@redhat.com \
--cc=juli@redhat.com \
--cc=junmuzi@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.