From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752328AbaIITRk (ORCPT ); Tue, 9 Sep 2014 15:17:40 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:34585 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbaIITRi (ORCPT ); Tue, 9 Sep 2014 15:17:38 -0400 X-Sasl-enc: NGclKyXHEU1+hAiW1j2MTZLTFlaZuovw9EVJc279Y2cR 1410290257 Date: Tue, 9 Sep 2014 12:17:36 -0700 From: Greg KH To: Markos Chandras Cc: linux-mips@linux-mips.org, Ricardo Ribalda Delgado , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions Message-ID: <20140909191736.GA7467@kroah.com> References: <1410263575-26720-1-git-send-email-markos.chandras@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1410263575-26720-1-git-send-email-markos.chandras@imgtec.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: > Commit e676253b19b2d269cccf67fdb1592120a0cd0676 > (serial/8250: Add support for RS485 IOCTLs) added cases for the > TIOC{S,G}RS485 commands but this broke the build for MIPS: > > drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl': > drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSRS485' undeclared > (first use in this function) > drivers/tty/serial/8250/8250_core.c:2886:7: error: 'TIOCGRS485' undeclared > (first use in this function) > > This patch adds these missing definitions > > Cc: Ricardo Ribalda Delgado > Cc: > Cc: > Cc: > Signed-off-by: Markos Chandras > --- > arch/mips/include/uapi/asm/ioctls.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/include/uapi/asm/ioctls.h b/arch/mips/include/uapi/asm/ioctls.h > index b1e637757fe3..34050cb6b631 100644 > --- a/arch/mips/include/uapi/asm/ioctls.h > +++ b/arch/mips/include/uapi/asm/ioctls.h > @@ -76,6 +76,8 @@ > > #define TIOCSBRK 0x5427 /* BSD compatibility */ > #define TIOCCBRK 0x5428 /* BSD compatibility */ > +#define TIOCGRS485 0x542E > +#define TIOCSRS485 0x542F Any reason you aren't using the _IOR() type macros here? thanks, greg k-h