From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33008)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XRSKt-0007tl-Ut
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 16:48:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XRSKn-0003qf-Qq
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 16:48:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:22576)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1XRSKn-0003qb-If
	for qemu-devel@nongnu.org; Tue, 09 Sep 2014 16:48:17 -0400
Date: Tue, 9 Sep 2014 23:51:22 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20140909205122.GB15637@redhat.com>
References: <1410265809-27247-1-git-send-email-pbonzini@redhat.com>
	<1410265809-27247-10-git-send-email-pbonzini@redhat.com>
	<20140909135424.GA13212@redhat.com> <540F35E3.7060207@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <540F35E3.7060207@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 09/10] piix: do not raise irq while loading
	vmstate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: amit.shah@redhat.com, dgilbert@redhat.com, qemu-devel@nongnu.org, Pavel.Dovgaluk@ispras.ru, quintela@redhat.com

On Tue, Sep 09, 2014 at 07:16:19PM +0200, Paolo Bonzini wrote:
> Il 09/09/2014 15:54, Michael S. Tsirkin ha scritto:
> > 
> > Hmm I don't understand.
> > You are removing call to piix3_update_irq_levels
> > this call is supposed to just sync up bus to
> > irq level.
> > 
> > How can this change system state? Saved state
> > is supposed to already be in sync.
> 
> i440FX/PIIX3 state is loaded before i8259, so the interrupt will never
> be in the i8259 ISR.  I am not sure why it is a problem for
> record/replay, but I think it's plausible to consider this a bug.  i8259
> state should not be affected by the load of PIIX3 state, since i8259 is
> migrated separately.
> 
> Paolo

Sorry I still don't understand. Why do stuff from vmstate callback then?
How is it different?

I'd like to see a description of a scenario where this patch makes
a difference.

-- 
MST