From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [PATCH] ACPI / platform / LPSS: disable async suspend/resume of LPSS devices Date: Wed, 10 Sep 2014 10:50:26 +0300 Message-ID: <20140910075026.GB13406@lahna.fi.intel.com> References: <540E91F0.2060306@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga11.intel.com ([192.55.52.93]:21032 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbaIJHua (ORCPT ); Wed, 10 Sep 2014 03:50:30 -0400 Content-Disposition: inline In-Reply-To: <540E91F0.2060306@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: "Fu, Zhonghui" Cc: rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org, "linux-kernel@vger.kernel.org" On Tue, Sep 09, 2014 at 01:36:48PM +0800, Fu, Zhonghui wrote: > >From 6deb00230f5df68da3ca7490402a0c537bf386bb Mon Sep 17 00:00:00 2001 > From: Fu Zhonghui > Date: Tue, 9 Sep 2014 13:02:25 +0800 > Subject: [PATCH] ACPI / platform / LPSS: disable async suspend/resume of LPSS devices > > LPSS devices must suspend/resume in fixed order. Or some LPSS devices > will hang during the transition to ACPI_STATE_D0 state. In addition to the comment from Rafael, I would like to have more details here why we must suspend/resume the LPSS devices in certain order. > > Signed-off-by: Li Aubrey > Signed-off-by: Fu Zhonghui > --- > drivers/acpi/acpi_lpss.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/acpi_lpss.c b/drivers/acpi/acpi_lpss.c > index fddc1e8..54e5c97 100644 > --- a/drivers/acpi/acpi_lpss.c > +++ b/drivers/acpi/acpi_lpss.c > @@ -419,7 +419,7 @@ static int acpi_lpss_create_device(struct acpi_device *adev, > adev->driver_data = pdata; > pdev = acpi_create_platform_device(adev); > if (!IS_ERR_OR_NULL(pdev)) { > - device_enable_async_suspend(&pdev->dev); > + device_disable_async_suspend(&pdev->dev); > return 1; > } > > -- 1.7.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html