From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
lgirdwood@gmail.com
Subject: Re: [PATCH v5 03/12] ALSA: control: Add init callback for kcontrol
Date: Wed, 10 Sep 2014 13:35:31 +0530 [thread overview]
Message-ID: <20140910080531.GC1770@intel.com> (raw)
In-Reply-To: <20140909114425.GU2601@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1236 bytes --]
On Tue, Sep 09, 2014 at 12:44:25PM +0100, Mark Brown wrote:
> On Mon, Sep 08, 2014 at 01:38:07PM +0530, Vinod Koul wrote:
>
> Please (as I'm sure has been pointed out before) fix your mailer to word
> wrap within paragraphs.
Oops, i though I had set mutt to fix it after you pointed out last time,
will check again.
>
> > On Mon, Sep 08, 2014 at 10:04:42AM +0200, Takashi Iwai wrote:
>
> > > For example, you can embed an init flag into your record and call the
> > > initializer in get/put callback if not called yet.
>
> > Yes but that would involve open coding in all control hanlers for the
> > driver :
>
> > if (!initialized) allocate_control_mem();
>
> > This approach was done earlier (checking in info) and flaged off by
> > Mark. It make better to have these handled in the framework.
>
> No, that's not the problem I identified. The bug you had was that the
> driver was initialising the data in only the info callback and would just
> fail if someone decided to call another callback first.
Yes and during the discussed we wanted to handle it in framework leading to
init callback.
Nevertheless we are moving it back to driver while fixing the bug you
pointed.
Thanks
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-09-10 8:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 12:35 [PATCH v5 00/12] Add mrfld DSP topology and widgets Subhransu S. Prusty
2014-09-02 12:35 ` [PATCH v5 01/12] ASoC: mfld: pcm: Replace pr_ with dev_ Subhransu S. Prusty
2014-09-06 14:21 ` Mark Brown
2014-09-02 12:35 ` [PATCH v5 02/12] ASoC: Intel: mfld-pcm: don't call trigger ops to DSP for internal streams Subhransu S. Prusty
2014-09-02 12:35 ` [PATCH v5 03/12] ALSA: control: Add init callback for kcontrol Subhransu S. Prusty
2014-09-06 14:21 ` Mark Brown
2014-09-06 15:56 ` Takashi Iwai
2014-09-08 4:14 ` Vinod Koul
2014-09-08 8:04 ` Takashi Iwai
2014-09-08 8:08 ` Vinod Koul
2014-09-08 8:36 ` Takashi Iwai
2014-09-08 11:08 ` Vinod Koul
2014-09-09 11:44 ` Mark Brown
2014-09-10 8:05 ` Vinod Koul [this message]
2014-09-02 12:35 ` [PATCH v5 04/12] ASoC: Intel: mrfld: add bytes control for modules Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 05/12] ASoC: Intel: mrfld: add the gain controls Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 06/12] ASoC: Intel: mfld-pcm: add control for powering up/down dsp Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 07/12] ASoC: Intel: mrfld: add DSP core controls Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 08/12] ASoC: Export dapm_kcontrol_get_value Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 09/12] ASoC: Intel: mrfld: add the DSP DAPM widgets Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 10/12] ASoC: Intel: mfld-pcm: add FE and BE ops Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 11/12] ASoC: Intel: mrfld: Use snd_soc_dai_get_drvdata to derive drv data Subhransu S. Prusty
2014-09-02 12:36 ` [PATCH v5 12/12] ASoC: Intel: mrfld: add the DSP mixers Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140910080531.GC1770@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.