From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRdK3-0005lv-3b for qemu-devel@nongnu.org; Wed, 10 Sep 2014 04:32:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRdJx-0002qS-Nu for qemu-devel@nongnu.org; Wed, 10 Sep 2014 04:32:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20868) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRdJx-0002qM-Gi for qemu-devel@nongnu.org; Wed, 10 Sep 2014 04:32:09 -0400 Date: Wed, 10 Sep 2014 10:32:00 +0200 From: Kevin Wolf Message-ID: <20140910083200.GB4052@noname.str.redhat.com> References: <1410284330-23325-1-git-send-email-cnanakos@grnet.gr> <20140910082021.GA4052@noname.str.redhat.com> <54100AF2.7000405@grnet.gr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54100AF2.7000405@grnet.gr> Subject: Re: [Qemu-devel] [PATCH v1 1/2] block/archipelago: Implement bdrv_truncate() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chrysostomos Nanakos Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 10.09.2014 um 10:25 hat Chrysostomos Nanakos geschrieben: > On 09/10/2014 11:20 AM, Kevin Wolf wrote: > >Am 09.09.2014 um 19:38 hat Chrysostomos Nanakos geschrieben: > >>Signed-off-by: Chrysostomos Nanakos > >>--- > >> block/archipelago.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++-- > >> 1 file changed, 61 insertions(+), 2 deletions(-) > >Thanks, applied all to the block branch. > > > >Can you please add a cover letter (the [PATCH 0/n] mail as produced by > >the --cover-letter option in git format-patch) for your next series? > > > >Kevin > Yes of course, removed it in the last minute thinking that it was > only two commits and there was no need for a cover letter. No big deal, but besides having combined diffstats, it also allows distinguishing between comments on the first patch and comments on the whole series, so I prefer to have it when it's more than one patch. Of course, you don't have to actually write a description for the cover letter for such a small series, the automatically generated stuff is good enough. Kevin