From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRftR-0002x3-EU for qemu-devel@nongnu.org; Wed, 10 Sep 2014 07:17:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRftL-0008BL-45 for qemu-devel@nongnu.org; Wed, 10 Sep 2014 07:16:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRftK-0008BD-T0 for qemu-devel@nongnu.org; Wed, 10 Sep 2014 07:16:51 -0400 Date: Wed, 10 Sep 2014 15:20:09 +0300 From: "Michael S. Tsirkin" Message-ID: <20140910122009.GA12045@redhat.com> References: <1410265809-27247-1-git-send-email-pbonzini@redhat.com> <1410265809-27247-5-git-send-email-pbonzini@redhat.com> <87bnqp2add.fsf@troll.troll> <540F008B.9030709@redhat.com> <20140910120200.GB11524@redhat.com> <54102F17.20307@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54102F17.20307@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/10] pcspk: adding vmstate for save/restore List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: amit.shah@redhat.com, dgilbert@redhat.com, qemu-devel@nongnu.org, Pavel.Dovgaluk@ispras.ru, quintela@redhat.com On Wed, Sep 10, 2014 at 12:59:35PM +0200, Paolo Bonzini wrote: > Il 10/09/2014 14:02, Michael S. Tsirkin ha scritto: > > That's not too hard: we need two types that only > > differ in the vmstate. > > Use the correct one to create the device depending > > on the pc type. > > > > Put in that light, we definitely did create new > > devices while keeping old ones around for > > compatibility. > > Do you have an example? I can think of one that we did in RHEL (hda) > but it was never upstream. > > Paolo Well the whole PC machine is exactly like this, isn't it? Also, xen plans to do something similar for igd passthrough, and I plan to do something similar for virtio 1.0. stdvga is somewhat similar. -- MST