From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH v3 02/17] ARM64 / ACPI: Get RSDP and ACPI boot-time tables Date: Wed, 10 Sep 2014 22:37:57 +0100 Message-ID: <20140910213757.C7B8CC40E5E@trevor.secretlab.ca> References: <1409583475-6978-1-git-send-email-hanjun.guo@linaro.org> <1409583475-6978-3-git-send-email-hanjun.guo@linaro.org> <20140909162648.GE2910@arm.com> Return-path: In-Reply-To: <20140909162648.GE2910@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Catalin Marinas , "hanjun.guo@linaro.org" Cc: "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , "graeme.gregory@linaro.org" , Arnd Bergmann , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" List-Id: linux-acpi@vger.kernel.org On Tue, 9 Sep 2014 17:26:49 +0100, Catalin Marinas wrote: > On Mon, Sep 01, 2014 at 03:57:40PM +0100, Hanjun Guo wrote: > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > index c96172a..fb7cc0e 100644 > > --- a/arch/arm64/kernel/setup.c > > +++ b/arch/arm64/kernel/setup.c > > @@ -43,6 +43,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -385,6 +386,9 @@ void __init setup_arch(char **cmdline_p) > > efi_init(); > > arm64_memblock_init(); > > > > + /* Parse the ACPI tables for possible boot-time configuration */ > > + acpi_boot_table_init(); > > Is there any dummy acpi_boot_table_init() when !CONFIG_ACPI? I couldn't > see one in this patch, so I don't see how this would compile when ACPI > is disabled. It's in include/linux/acpi.h in the !CONFIG_ACPI section. g. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753731AbaIKI6c (ORCPT ); Thu, 11 Sep 2014 04:58:32 -0400 Received: from mail-wi0-f176.google.com ([209.85.212.176]:44144 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753408AbaIKI60 (ORCPT ); Thu, 11 Sep 2014 04:58:26 -0400 From: Grant Likely Subject: Re: [PATCH v3 02/17] ARM64 / ACPI: Get RSDP and ACPI boot-time tables To: Catalin Marinas , "hanjun.guo@linaro.org" Cc: "Rafael J. Wysocki" , Mark Rutland , Olof Johansson , "graeme.gregory@linaro.org" , Arnd Bergmann , Sudeep Holla , Will Deacon , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Daniel Lezcano , Mark Brown , Rob Herring , Robert Richter , Lv Zheng , Robert Moore , Lorenzo Pieralisi , Liviu Dudau , Randy Dunlap , Charles Garcia-Tobin , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" , Al Stone , Tomasz Nowicki In-Reply-To: <20140909162648.GE2910@arm.com> References: <1409583475-6978-1-git-send-email-hanjun.guo@linaro.org> <1409583475-6978-3-git-send-email-hanjun.guo@linaro.org> <20140909162648.GE2910@arm.com> Date: Wed, 10 Sep 2014 22:37:57 +0100 Message-Id: <20140910213757.C7B8CC40E5E@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Sep 2014 17:26:49 +0100, Catalin Marinas wrote: > On Mon, Sep 01, 2014 at 03:57:40PM +0100, Hanjun Guo wrote: > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > index c96172a..fb7cc0e 100644 > > --- a/arch/arm64/kernel/setup.c > > +++ b/arch/arm64/kernel/setup.c > > @@ -43,6 +43,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -385,6 +386,9 @@ void __init setup_arch(char **cmdline_p) > > efi_init(); > > arm64_memblock_init(); > > > > + /* Parse the ACPI tables for possible boot-time configuration */ > > + acpi_boot_table_init(); > > Is there any dummy acpi_boot_table_init() when !CONFIG_ACPI? I couldn't > see one in this patch, so I don't see how this would compile when ACPI > is disabled. It's in include/linux/acpi.h in the !CONFIG_ACPI section. g. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grant.likely@linaro.org (Grant Likely) Date: Wed, 10 Sep 2014 22:37:57 +0100 Subject: [PATCH v3 02/17] ARM64 / ACPI: Get RSDP and ACPI boot-time tables In-Reply-To: <20140909162648.GE2910@arm.com> References: <1409583475-6978-1-git-send-email-hanjun.guo@linaro.org> <1409583475-6978-3-git-send-email-hanjun.guo@linaro.org> <20140909162648.GE2910@arm.com> Message-ID: <20140910213757.C7B8CC40E5E@trevor.secretlab.ca> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 9 Sep 2014 17:26:49 +0100, Catalin Marinas wrote: > On Mon, Sep 01, 2014 at 03:57:40PM +0100, Hanjun Guo wrote: > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > index c96172a..fb7cc0e 100644 > > --- a/arch/arm64/kernel/setup.c > > +++ b/arch/arm64/kernel/setup.c > > @@ -43,6 +43,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -385,6 +386,9 @@ void __init setup_arch(char **cmdline_p) > > efi_init(); > > arm64_memblock_init(); > > > > + /* Parse the ACPI tables for possible boot-time configuration */ > > + acpi_boot_table_init(); > > Is there any dummy acpi_boot_table_init() when !CONFIG_ACPI? I couldn't > see one in this patch, so I don't see how this would compile when ACPI > is disabled. It's in include/linux/acpi.h in the !CONFIG_ACPI section. g.