From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 11 Sep 2014 01:46:05 +0200
Subject: [U-Boot] [PATCH] e1000: add i211 and unprogrammed i210/i211
	support
In-Reply-To: <1410383900.16012.24.camel@localhost.localdomain>
References: <03c9982d8450bcbf073530edd6446ef3ec4dfddb.1410127137.git.marcel@ziswiler.com>
	<201409080407.59778.marex@denx.de>
	<1410383900.16012.24.camel@localhost.localdomain>
Message-ID: <201409110146.05991.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wednesday, September 10, 2014 at 11:18:20 PM, Marcel Ziswiler wrote:
> On Mon, 2014-09-08 at 04:07 +0200, Marek Vasut wrote:
> > Does the network really work with an i21x with unprogrammed iNVM ?
> 
> Yes, it actually does work quite nicely.

That's interesting. I never got it working with unprogrammed iNVM, I always had 
to program it first.

> However I currently still have to patch it additionally as follows:
> 
> diff --git a/drivers/net/e1000.c b/drivers/net/e1000.c
> index ce19173..5f9c606 100644
> --- a/drivers/net/e1000.c
> +++ b/drivers/net/e1000.c
> @@ -1128,7 +1128,7 @@ e1000_swfw_sync_acquire(struct e1000_hw *hw,
> uint16_t mask)
> 
>         if (!timeout) {
>                 DEBUGOUT("Driver can't access resource, SW_FW_SYNC
> timeout.\n");
> -               return -E1000_ERR_SWFW_SYNC;
> +//             return -E1000_ERR_SWFW_SYNC;
>         }
> 
>         swfw_sync |= swmask;
> @@ -4378,7 +4378,7 @@ e1000_get_phy_cfg_done(struct e1000_hw *hw)
>                 if (!timeout) {
>                         DEBUGOUT("MNG configuration cycle has not "
>                                         "completed.\n");
> -                       return -E1000_ERR_RESET;
> +//                     return -E1000_ERR_RESET;
>                 }
>                 break;
>         }
> 
> Without doing the above it fails as follows (enabled E1000_DEBUG):

[...]

> This is both with programmed (iNVM only, haven't tried external serial
> PROM possible on i210) as well as unprogrammed i210 as well as i211
> chips on our Apalis T30 modules.
> 
> Have you ever seen any such issue?

No, but this looks like the card cannot acquire a semaphore. You might want to 
check if there are maybe some pecularities in semaphore handling on this i210 
hardware. I remember intel did change the semaphore handling between various 
intel ethernet cards.

> Wondering whether this is a Tegra PCIe related issue.

I doubt so.

> May I ask about your specific platform you tried this on?

The MX6 SabreLite and the MX6 SabreSDP . Both MX6Quad.

> Could you send some output of a working session with
> E1000_DEBUG enabled? I plan to try it on a Boundary Devices Nitrogen6X
> as well as our Apalis iMX6 module as well.

I don't have the setup assembled now and the i210 is not available to me now, 
but you should be getting the same result with the N6X. Right now, I only have 
the MX6 SabreLite and an another intel NIC available, sorry.

Best regards,
Marek Vasut