From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [libvirt] [PATCH V3 4/5] libxl: fix mapping of lifecycle actions Date: Thu, 11 Sep 2014 11:47:16 +0100 Message-ID: <20140911104716.GD7035__41727.3307372399$1410432552$gmane$org@redhat.com> References: <1409800059-16884-1-git-send-email-jfehlig@suse.com> <1409800059-16884-5-git-send-email-jfehlig@suse.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1409800059-16884-5-git-send-email-jfehlig@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jim Fehlig Cc: libvir-list@redhat.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Wed, Sep 03, 2014 at 09:07:38PM -0600, Jim Fehlig wrote: > The libxl driver was blindly assigning libvirt's > virDomainLifecycleAction to libxl's libxl_action_on_shutdown, when > in fact the various actions take on different values in these enums. > > Introduce helpers to properly map the enum values. > > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_conf.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 59 insertions(+), 3 deletions(-) ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|