From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Peter Hutterer <peter.hutterer@redhat.com>,
Benjamin Tissoires <btissoir@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads
Date: Thu, 11 Sep 2014 10:26:19 -0700 [thread overview]
Message-ID: <20140911172619.GD13083@core.coreip.homeip.net> (raw)
In-Reply-To: <1410425447-9575-3-git-send-email-hdegoede@redhat.com>
Hi Hans,
On Thu, Sep 11, 2014 at 10:50:47AM +0200, Hans de Goede wrote:
> @@ -722,6 +723,13 @@ static int psmouse_extensions(struct psmouse *psmouse,
> {
> bool synaptics_hardware = false;
>
> +/* Always check for focaltech, this is safe as it uses pnp-id matching */
> + if (psmouse_do_detect(focaltech_detect, psmouse, set_properties) == 0) {
> + /* Not supported yet, use bare protocol */
> + psmouse_max_proto = max_proto = PSMOUSE_PS2;
> + goto reset_to_defaults;
Why do we need to jump to a new label instead of simply saying
return PSMOUSE_PS2;
> + }
> +
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-09-11 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 8:50 [PATCH 1/3] i8042: Also store the aux firmware id in multi-plexed aux ports Hans de Goede
2014-09-11 8:50 ` [PATCH 2/3] psmouse: Add psmouse_matches_pnp_id helper function Hans de Goede
2014-09-11 8:50 ` [PATCH 3/3] psmouse: Add support for detecting FocalTech PS/2 touchpads Hans de Goede
2014-09-11 17:26 ` Dmitry Torokhov [this message]
2014-09-11 17:31 ` Hans de Goede
2014-09-12 6:14 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140911172619.GD13083@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=btissoir@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=peter.hutterer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.