All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] qt: make QtDeclarative depend on QtSql
@ 2014-09-12  2:21 Danomi Manchego
  2014-09-12  7:35 ` Thomas Petazzoni
  2015-01-24  0:10 ` Peter Korsgaard
  0 siblings, 2 replies; 4+ messages in thread
From: Danomi Manchego @ 2014-09-12  2:21 UTC (permalink / raw)
  To: buildroot

As indicated by QtDeclarative.pc, QtDeclarative needs QtSql.
It builds fine without it, but then you get a run-time error.
So add QtSql to the QtDeclarative depends-on list.

Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
---
 package/qt/Config.in |    1 +
 1 file changed, 1 insertion(+)

diff --git a/package/qt/Config.in b/package/qt/Config.in
index da159b4..1f3e5fb 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -419,6 +419,7 @@ config BR2_PACKAGE_QT_DECLARATIVE
 	bool "Declarative module"
 	depends on BR2_PACKAGE_QT_SCRIPT
 	depends on BR2_PACKAGE_QT_GUI_MODULE
+	depends on BR2_PACKAGE_QT_SQL_MODULE
 	help
 	  Build the Qt Declarative Module for qml support
 	  if unsure, say n.
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] qt: make QtDeclarative depend on QtSql
  2014-09-12  2:21 [Buildroot] [PATCH 1/1] qt: make QtDeclarative depend on QtSql Danomi Manchego
@ 2014-09-12  7:35 ` Thomas Petazzoni
  2014-09-12 13:58   ` Danomi Manchego
  2015-01-24  0:10 ` Peter Korsgaard
  1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2014-09-12  7:35 UTC (permalink / raw)
  To: buildroot

Dear Danomi Manchego,

On Thu, 11 Sep 2014 22:21:35 -0400, Danomi Manchego wrote:
> As indicated by QtDeclarative.pc, QtDeclarative needs QtSql.
> It builds fine without it, but then you get a run-time error.
> So add QtSql to the QtDeclarative depends-on list.
> 
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
> ---
>  package/qt/Config.in |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index da159b4..1f3e5fb 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -419,6 +419,7 @@ config BR2_PACKAGE_QT_DECLARATIVE
>  	bool "Declarative module"
>  	depends on BR2_PACKAGE_QT_SCRIPT
>  	depends on BR2_PACKAGE_QT_GUI_MODULE
> +	depends on BR2_PACKAGE_QT_SQL_MODULE
>  	help
>  	  Build the Qt Declarative Module for qml support
>  	  if unsure, say n.

Not really related to your patch, but why do we use "depends on"
instead of "select" here? How am I supposed to know that I need to
enable Sql stuff to be able to build the Declarative module?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] qt: make QtDeclarative depend on QtSql
  2014-09-12  7:35 ` Thomas Petazzoni
@ 2014-09-12 13:58   ` Danomi Manchego
  0 siblings, 0 replies; 4+ messages in thread
From: Danomi Manchego @ 2014-09-12 13:58 UTC (permalink / raw)
  To: buildroot

Thomas,

On Fri, Sep 12, 2014 at 3:35 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Danomi Manchego,
>
> On Thu, 11 Sep 2014 22:21:35 -0400, Danomi Manchego wrote:
>> As indicated by QtDeclarative.pc, QtDeclarative needs QtSql.
>> It builds fine without it, but then you get a run-time error.
>> So add QtSql to the QtDeclarative depends-on list.
>>
>> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
>> ---
>>  package/qt/Config.in |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/qt/Config.in b/package/qt/Config.in
>> index da159b4..1f3e5fb 100644
>> --- a/package/qt/Config.in
>> +++ b/package/qt/Config.in
>> @@ -419,6 +419,7 @@ config BR2_PACKAGE_QT_DECLARATIVE
>>       bool "Declarative module"
>>       depends on BR2_PACKAGE_QT_SCRIPT
>>       depends on BR2_PACKAGE_QT_GUI_MODULE
>> +     depends on BR2_PACKAGE_QT_SQL_MODULE
>>       help
>>         Build the Qt Declarative Module for qml support
>>         if unsure, say n.
>
> Not really related to your patch, but why do we use "depends on"
> instead of "select" here? How am I supposed to know that I need to
> enable Sql stuff to be able to build the Declarative module?

I don't know why its that way (depends-on, no comment to indicated why
it's hidden).

Looking back at the history, most of the additions like this were
"depends on".  Most of the mods that added "select" were to select
non-Qt switches.  The commits logs that I scanned don't comment on one
versus the other, except for these two exceptions.

4059a814bb133d4dc306a366cdeba186cb7b8b89 - depends-on gstreamer used
due to complicated gstreamer dependencies.
d018125508c1d13f69b71702384c00c7095986a1 - qt-dbus: replace dependency
on dbus by select

For this particular case, I would have used a "select" if there were
not already pre-existing similar conditions.  (Similar in the sense
that they were also qt-config-related.)

The reason why I stumbled on to this is that I was attempting to
reduce my total ubifs file size be deselecting stuff.  Then my qml app
failed to load due to lack of QtSql.  So I figured that I'd patch, to
save my future self and others from the same fate.

Danomi -


> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH 1/1] qt: make QtDeclarative depend on QtSql
  2014-09-12  2:21 [Buildroot] [PATCH 1/1] qt: make QtDeclarative depend on QtSql Danomi Manchego
  2014-09-12  7:35 ` Thomas Petazzoni
@ 2015-01-24  0:10 ` Peter Korsgaard
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2015-01-24  0:10 UTC (permalink / raw)
  To: buildroot

>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:

Hi,

 > As indicated by QtDeclarative.pc, QtDeclarative needs QtSql.
 > It builds fine without it, but then you get a run-time error.
 > So add QtSql to the QtDeclarative depends-on list.

 > Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-01-24  0:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-12  2:21 [Buildroot] [PATCH 1/1] qt: make QtDeclarative depend on QtSql Danomi Manchego
2014-09-12  7:35 ` Thomas Petazzoni
2014-09-12 13:58   ` Danomi Manchego
2015-01-24  0:10 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.