From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSX0p-00050g-1k for qemu-devel@nongnu.org; Fri, 12 Sep 2014 16:00:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSX0g-0004AC-FN for qemu-devel@nongnu.org; Fri, 12 Sep 2014 16:00:06 -0400 Received: from mail-qa0-x233.google.com ([2607:f8b0:400d:c00::233]:37709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSX0g-00049P-At for qemu-devel@nongnu.org; Fri, 12 Sep 2014 15:59:58 -0400 Received: by mail-qa0-f51.google.com with SMTP id i13so1225647qae.24 for ; Fri, 12 Sep 2014 12:59:56 -0700 (PDT) Date: Fri, 12 Sep 2014 15:59:52 -0400 From: "Gabriel L. Somlo" Message-ID: <20140912195951.GK1825@ERROL.INI.CMU.EDU> References: <20140911154159.GB1825@ERROL.INI.CMU.EDU> <5411C474.6050105@redhat.com> <20140911163508.GC1825@ERROL.INI.CMU.EDU> <5411D086.8030400@redhat.com> <20140911201638.GF1825@ERROL.INI.CMU.EDU> <1410504379.30411.3.camel@nilsson.home.kraxel.org> <20140912181806.GI1825@ERROL.INI.CMU.EDU> <54133AB9.7080508@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54133AB9.7080508@redhat.com> Subject: Re: [Qemu-devel] OVMF, Q35 and USB keyboard/mouse List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: edk2-devel@lists.sourceforge.net, agraf@suse.de, qemu-devel@nongnu.org, Gerd Hoffmann , reza.jelveh@tuhh.de, lersek@redhat.com On Fri, Sep 12, 2014 at 08:26:01PM +0200, Paolo Bonzini wrote: > So it could be an OVMF bug related to multifunction devices. > > Well, you could try moving devices around in different functions. > You could try moving ehci1 to 0 and the UHCIs to 1/2/7. > > Or drop uhci2/uhci3 and move the two remaining devices around. Once you > have three combinations that work (e.g. 0/4, 0/6, 0/7) you could use it > to add three UHCI controllers (in the above examples, it would be 0/1/2/7). > > Remember that one of the two must be xx.0, the other can be anything > from xx.1 to xx.7. I moved things around as you suggested (from hw/usb/hcd-ehci-pci.c and the ich9_1d[] array). No matter which PCI function gets assigned to which device, and no matter which order the uhci1/2/3 devices are listed in ich9_1d[], it's *always* uhci3 (dev.id. 2936) and ehci being shown, and uhci1&2 end up missing. System Information looks like this (high-speed kbd/mouse patch is applied, so I'm looking for whether uhci2/3 show up in the list or not, but wanted to always have mouse and keyboard available on ehci): USB Device Tree: --->USB Bus<--- v USB Hi-Speed Bus QEMU USB Keyboard QEMU USB Mouse USB Bus: Host Controller Location: Expansion Slot Host Controller Driver: AppleUSBUHCI PCI Device ID: 0x2936 PCI Revision ID: 0x0003 PCI Vendor ID: 0x8086 Bus Number: 0x5d The bus number varies (depending on which function I hard-coded for uhci3, e.g. 3d when I had it at 00:1d.1, 5d for the default 00:1d.2, etc.) but it's always uhci3... Interestingly, if I comment out uhci3, it's only ehci that shows up, not uhci1 or uhci2 (even though one of them is 00:1d.0). Feels like there's some thing "magical" about the uhci3 name or device ID. Maybe at this point I should go fishing in the edk2 source :) Thanks, --Gabriel