All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3 1/4] drm/i915: Move the cursor_base setup to i{845, 9xx}_update_cursor()
Date: Sat, 13 Sep 2014 17:15:35 +0100	[thread overview]
Message-ID: <20140913161535.GN16043@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1410544415-3059-1-git-send-email-ville.syrjala@linux.intel.com>

On Fri, Sep 12, 2014 at 08:53:32PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> To make the code a bit more undestandable move the
> intel_crtc->cursor_base assignment into the low level update cursor
> routines. That's were we compare the current value with the new one
> so immediately seeing that it gets assigned only afterwards helps
> one to understand that it gets assigned only after the comparison.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

I'd been tempted to do this myself, but lacked justification.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

      parent reply	other threads:[~2014-09-13 16:15 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12 13:48 [PATCH] drm/i915: Support variable cursor height on ivb+ ville.syrjala
2014-09-12 14:00 ` [PATCH v2] " ville.syrjala
2014-09-12 17:53   ` [PATCH v3 1/4] drm/i915: Move the cursor_base setup to i{845, 9xx}_update_cursor() ville.syrjala
2014-09-12 17:53     ` [PATCH v3 2/4] drm/i915: Only set CURSOR_PIPE_CSC_ENABLE when cursor is enabled ville.syrjala
2014-09-13 16:17       ` Chris Wilson
2014-09-15  9:12         ` Daniel Vetter
2014-09-12 17:53     ` [PATCH v3 3/4] drm/i915: Skip CURBASE write when nothing changed ville.syrjala
2014-09-13 16:20       ` Chris Wilson
2014-09-15 13:36         ` Ville Syrjälä
2014-09-15 13:46           ` Chris Wilson
2014-09-12 17:53     ` [PATCH v3 4/4] drm/i915: Support variable cursor height on ivb+ ville.syrjala
2014-09-13 16:23       ` Chris Wilson
2014-09-15 13:31         ` Ville Syrjälä
2014-09-13 16:15     ` Chris Wilson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140913161535.GN16043@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.