From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH v3 4/4] drm/i915: Support variable cursor height on ivb+ Date: Sat, 13 Sep 2014 17:23:23 +0100 Message-ID: <20140913162323.GQ16043@nuc-i3427.alporthouse.com> References: <1410530426-4905-1-git-send-email-ville.syrjala@linux.intel.com> <1410544415-3059-1-git-send-email-ville.syrjala@linux.intel.com> <1410544415-3059-4-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from fireflyinternet.com (mail.fireflyinternet.com [87.106.93.118]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D3886E185 for ; Sat, 13 Sep 2014 09:23:28 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1410544415-3059-4-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Sep 12, 2014 at 08:53:35PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > IVB introduced the CUR_FBC_CTL register which allows reducing the cursor > height down to 8 lines from the otherwise square cursor dimensions. > Implement support for it. > = > Commandeer the otherwise unused intel_crtc->cursor_size to track the > current value of CUR_FBC_CTL so that we can avoid duplicating the > complicated device type checks in i9xx_update_cursor(). > = > One caveat to note is that CUR_FBC_CTL can't be used with 180 degree > rotation, so when cursor rotation gets introduced some extra checks are > needed. Where would be a good place to put that note into a comment? So other than the mystery of rotated cursors, the code looks clear enough. One side question, is the CHV/VLV conflation correct here? -Chris -- = Chris Wilson, Intel Open Source Technology Centre