From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbaIMRut (ORCPT ); Sat, 13 Sep 2014 13:50:49 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38825 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbaIMRus (ORCPT ); Sat, 13 Sep 2014 13:50:48 -0400 Date: Sat, 13 Sep 2014 10:50:47 -0700 From: Christoph Hellwig To: Hans de Goede Cc: Christoph Hellwig , linux-usb , SCSI development list , Linux Kernel Mailing List Subject: Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq Message-ID: <20140913175047.GA28882@infradead.org> References: <540EC52C.3000804@redhat.com> <20140909152730.GA17882@infradead.org> <540FFBF4.9090001@redhat.com> <20140910154535.GA5102@infradead.org> <541172E9.8070309@redhat.com> <20140911161331.GA24488@infradead.org> <54134E50.6040805@redhat.com> <20140912230032.GA21143@infradead.org> <54141C59.7040707@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54141C59.7040707@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 13, 2014 at 12:28:41PM +0200, Hans de Goede wrote: > Yes this one does the trick and fixes things. Note the git tree I used for > testing also had your previous fix to split up the blk_tcq union in 2 > separate struct members. Let me know if you want me to re-test without that > fix. I'm pretty sure that isn't needed, so double testing it indeed doesn't would be helpful. I'd like to add your Tested-by: tag after that, too.