All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Anton Blanchard <anton@samba.org>,
	a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf symbols: Add path to Ubuntu kernel debuginfo file
Date: Mon, 15 Sep 2014 16:57:02 -0300	[thread overview]
Message-ID: <20140915195702.GG2259@redhat.com> (raw)
In-Reply-To: <87d2b1mj8v.fsf@sejong.aot.lge.com>

Em Fri, Sep 12, 2014 at 03:43:28PM +0900, Namhyung Kim escreveu:
> On Tue, 9 Sep 2014 09:11:52 +1000, Anton Blanchard wrote:
> > Ubuntu places the kernel debuginfo in /usr/lib/debug/boot/vmlinux-*
> >
> > Signed-off-by: Anton Blanchard <anton@samba.org>
> 
> It seems that you need to rebase it onto current acme/perf/core as
> there're little change in this area.  The patch itself looks good to me.

I updated the patch, to make it use the kernel_version from the
perf.data file if present, else it uses uts.release as in Anton's patch,
ok?

- Arnaldo
 
> Thanks,
> Namhyung
> 
> 
> > ---
> >
> > Index: b/tools/perf/util/symbol.c
> > ===================================================================
> > --- a/tools/perf/util/symbol.c
> > +++ b/tools/perf/util/symbol.c
> > @@ -1750,7 +1750,7 @@ static int vmlinux_path__init(void)
> >  	struct utsname uts;
> >  	char bf[PATH_MAX];
> >  
> > -	vmlinux_path = malloc(sizeof(char *) * 5);
> > +	vmlinux_path = malloc(sizeof(char *) * 6);
> >  	if (vmlinux_path == NULL)
> >  		return -1;
> >  
> > @@ -1784,6 +1784,12 @@ static int vmlinux_path__init(void)
> >  		 uts.release);
> >  	vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
> >  	if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
> > +		goto out_fail;
> > +	++vmlinux_path__nr_entries;
> > +	snprintf(bf, sizeof(bf), "/usr/lib/debug/boot/vmlinux-%s",
> > +		 uts.release);
> > +	vmlinux_path[vmlinux_path__nr_entries] = strdup(bf);
> > +	if (vmlinux_path[vmlinux_path__nr_entries] == NULL)
> >  		goto out_fail;
> >  	++vmlinux_path__nr_entries;
> >  

  reply	other threads:[~2014-09-15 19:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 23:11 [PATCH] perf symbols: Add path to Ubuntu kernel debuginfo file Anton Blanchard
2014-09-12  6:43 ` Namhyung Kim
2014-09-15 19:57   ` Arnaldo Carvalho de Melo [this message]
2014-09-19  5:22 ` [tip:perf/core] " tip-bot for Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140915195702.GG2259@redhat.com \
    --to=acme@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.