From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "René Scharfe" <l.s.r@web.de>,
"Git Mailing List" <git@vger.kernel.org>,
"Stefan Beller" <stefanbeller@gmail.com>
Subject: Re: [PATCH 2/3] make update-server-info more robust
Date: Mon, 15 Sep 2014 19:56:59 -0400 [thread overview]
Message-ID: <20140915235659.GA5019@peff.net> (raw)
In-Reply-To: <xmqqlhpk7mpb.fsf@gitster.dls.corp.google.com>
On Mon, Sep 15, 2014 at 11:39:12AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Since "git update-server-info" may be called automatically
> > as part of a push or a "gc --auto", we should be robust
> > against two processes trying to update it simultaneously.
> > However, we currently use a fixed tempfile, which means that
> > two simultaneous writers may step on each other's toes and
> > end up renaming junk into place.
>
> Thanks. I'll queue these clean-ups but we may want to start
> thinking about deprecating and removing the dumb http support.
Yeah, I have often thought about that (especially the push support,
which has always been flaky and underused). However, some possible
schemes for resumable clone could be easily implemented by shunting the
cloner to a dumb-http conversation. So it may be worth keeping at least
the fetch side around for the time being. Food for thought.
-Peff
next prev parent reply other threads:[~2014-09-15 23:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-13 7:28 [PATCH] repack: call prune_packed_objects() and update_server_info() directly René Scharfe
2014-09-13 8:59 ` Stefan Beller
2014-09-13 20:15 ` Jeff King
2014-09-13 20:16 ` [PATCH 1/3] prune-packed: fix minor memory leak Jeff King
2014-09-13 20:19 ` [PATCH 2/3] make update-server-info more robust Jeff King
2014-09-14 17:38 ` René Scharfe
2014-09-15 18:39 ` Junio C Hamano
2014-09-15 23:56 ` Jeff King [this message]
2014-09-13 20:19 ` [PATCH 3/3] server-info: clean up after writing info/packs Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140915235659.GA5019@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.