All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: check EA value offset when loading
Date: Tue, 16 Sep 2014 14:41:16 -0400	[thread overview]
Message-ID: <20140916184116.GJ6205@thunk.org> (raw)
In-Reply-To: <20140914173259.31996.39833.stgit@birch.djwong.org>

On Sun, Sep 14, 2014 at 10:32:59AM -0700, Darrick J. Wong wrote:
> When loading extended attributes, check each entry's value offset to
> make sure it doesn't collide with the entries.
> 
> Without this check it is easy to crash the kernel by mounting a
> malicious FS containing a file with an EA wherein e_value_offs = 0 and
> e_value_size > 0 and then deleting the EA, which corrupts the name
> list.
> 
> (See the f_ea_value_crash test's FS image in e2fsprogs for an example.)
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Thanks, applied.

					- Ted

  reply	other threads:[~2014-09-16 18:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-14 17:32 [PATCH 0/2] ext4/jbd2: misc 3.17 bugfixes, part 2 Darrick J. Wong
2014-09-14 17:32 ` [PATCH 1/2] ext4: check EA value offset when loading Darrick J. Wong
2014-09-16 18:41   ` Theodore Ts'o [this message]
2014-09-14 17:33 ` [PATCH 2/2] jbd2: free bh when descriptor block checksum fails Darrick J. Wong
2014-09-14 19:13   ` Eric Sandeen
2014-09-16 18:43     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140916184116.GJ6205@thunk.org \
    --to=tytso@mit.edu \
    --cc=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.