From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755136AbaIPTxQ (ORCPT ); Tue, 16 Sep 2014 15:53:16 -0400 Received: from gw-1.arm.linux.org.uk ([78.32.30.217]:59285 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754605AbaIPTxP (ORCPT ); Tue, 16 Sep 2014 15:53:15 -0400 Date: Tue, 16 Sep 2014 20:52:55 +0100 From: Russell King - ARM Linux To: Ulf Hansson Cc: Krzysztof Kozlowski , Dan Williams , Vinod Koul , "linux-kernel@vger.kernel.org" , dmaengine@vger.kernel.org, Grant Likely , Lars-Peter Clausen , Michal Simek , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Randy Dunlap , Alan Stern , "linux-doc@vger.kernel.org" , "linux-pm@vger.kernel.org" , Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v5 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM Message-ID: <20140916195255.GN12361@n2100.arm.linux.org.uk> References: <1410872360-27029-1-git-send-email-k.kozlowski@samsung.com> <1410872360-27029-4-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 16, 2014 at 08:25:25PM +0200, Ulf Hansson wrote: > On 16 September 2014 14:59, Krzysztof Kozlowski wrote: > > The AMBA bus driver defines runtime Power Management functions which > > disable and unprepare AMBA bus clock. This is problematic for runtime PM > > because unpreparing a clock might sleep so it is not interrupt safe. > > > > However some drivers may want to implement runtime PM functions in > > interrupt-safe way (see pm_runtime_irq_safe()). In such case the AMBA > > bus driver should only disable/enable the clock in runtime suspend and > > resume callbacks. > > > > Detect the device driver behavior after calling its probe function and > > store it. During runtime suspend/resume deal with clocks according to > > stored value. > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > drivers/amba/bus.c | 29 +++++++++++++++++++++++++---- > > include/linux/amba/bus.h | 1 + > > 2 files changed, 26 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c > > index 3cf61a127ee5..e8fd5706954f 100644 > > --- a/drivers/amba/bus.c > > +++ b/drivers/amba/bus.c > > @@ -94,8 +94,18 @@ static int amba_pm_runtime_suspend(struct device *dev) > > struct amba_device *pcdev = to_amba_device(dev); > > int ret = pm_generic_runtime_suspend(dev); > > > > - if (ret == 0 && dev->driver) > > - clk_disable_unprepare(pcdev->pclk); > > + if (ret == 0 && dev->driver) { > > + /* > > + * Drivers should not change pm_runtime_irq_safe() > > + * after probe. > > + */ > > + WARN_ON(pcdev->irq_safe != pm_runtime_is_irq_safe(dev)); > > Do we really need a WARN_ON here. Driver shouldn't update their > irq_safe value dynamically, right!? The driver shouldn't update it dynamically, and this makes sure *that* is enforced since we end up depending on that property. Hence the check is sensible (and I even suggested it.) > > + > > + if (pcdev->irq_safe) > > + clk_disable(pcdev->pclk); > > Since the irq_safe flag, could be considered as a special case, an > option for these cases - could be to leave the clock to be entirely > handled from the driver's runtime PM callback instead. Too many sub-clauses to make much sense of that statement. I don't want drivers messing around with this stuff. This is the /bus/ clock, not a device specific clock. -- FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.