From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2 V2] xfs_db: add crc manipulation commands
Date: Wed, 17 Sep 2014 09:52:28 +1000 [thread overview]
Message-ID: <20140916235228.GQ4322@dastard> (raw)
In-Reply-To: <5418B459.1010204@sandeen.net>
On Tue, Sep 16, 2014 at 05:06:17PM -0500, Eric Sandeen wrote:
> On 9/16/14 10:29 AM, Eric Sandeen wrote:
> > This adds a new "crc" command to xfs_db for CRC-enabled filesystems.
> >
> > If a structure has a CRC field, we can validate it, invalidate/corrupt
> > it, or revalidate/rewrite it:
> >
> > xfs_db> sb 0
> > xfs_db> crc -v
> > crc = 0x796c814f (correct)
> > xfs_db> crc -i
> > Metadata CRC error detected at block 0x0/0x200
> > crc = 0x796c8150 (bad)
> > xfs_db> crc -r
> > crc = 0x796c814f (correct)
>
> On reflection, do you think these should be more verbose, something like:
>
> xfs_db> sb 0
> xfs_db> crc -v
> Validating crc:
> crc = 0x796c814f (correct)
> xfs_db> crc -i
> Invalidating CRC:
> Metadata CRC error detected at block 0x0/0x200
> crc = 0x796c8150 (bad)
> xfs_db> crc -r
> Rewriting CRC:
> crc = 0x796c814f (correct)
Seems like a good idea to me. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-09-16 23:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 17:25 [PATCH 0/2] xfsprogs: xfs_db crc fixes/changes Eric Sandeen
2014-09-06 17:46 ` [PATCH 1/2] xfs_db: fix inode CRC validity state, and warn on read if invalid Eric Sandeen
2014-09-06 23:00 ` Dave Chinner
2014-09-06 17:52 ` [PATCH 2/2] xfsprogs: xfs_db: add crc manipulation commands Eric Sandeen
2015-03-09 15:47 ` Eric Sandeen
2014-09-16 15:26 ` [PATCH 1/2 V2] xfs_db: fix inode CRC validity state, and warn on read if invalid Eric Sandeen
2014-09-16 15:29 ` [PATCH 2/2 V2] xfs_db: add crc manipulation commands Eric Sandeen
2014-09-16 22:06 ` Eric Sandeen
2014-09-16 23:52 ` Dave Chinner [this message]
2014-09-17 2:15 ` [PATCH 2/2 V3] " Eric Sandeen
2015-03-02 23:48 ` [PATCH 0/2] xfsprogs: xfs_db crc fixes/changes Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140916235228.GQ4322@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.