From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41662)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XU50R-0005FR-Ij
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 22:30:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XU50L-0007K7-FV
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 22:30:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65400)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XU50L-0007Jh-7v
	for qemu-devel@nongnu.org; Tue, 16 Sep 2014 22:30:01 -0400
Date: Wed, 17 Sep 2014 10:29:52 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140917022952.GB16646@fam-t430.nay.redhat.com>
References: <1410877464-20481-1-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1410877464-20481-1-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: delete cow block driver
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, shhuiw@163.com, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>

On Tue, 09/16 15:24, Stefan Hajnoczi wrote:
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index a685d02..56302c7 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -197,7 +197,7 @@
>  #       'file', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',
>  #       'host_floppy', 'http', 'https', 'nbd', 'parallels', 'qcow',
>  #       'qcow2', 'raw', 'tftp', 'vdi', 'vmdk', 'vpc', 'vvfat'
> -#       2.2: 'archipelago'
> +#       2.2: 'archipelago' added, 'cow' dropped
>  #
>  # @backing_file: #optional the name of the backing file (for copy-on-write)
>  #
> @@ -1149,7 +1149,7 @@
>  { 'enum': 'BlockdevDriver',
>    'data': [ 'archipelago', 'file', 'host_device', 'host_cdrom', 'host_floppy',
>              'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'blkdebug',
> -            'blkverify', 'bochs', 'cloop', 'cow', 'dmg', 'parallels', 'qcow',
> +            'blkverify', 'bochs', 'cloop', 'dmg', 'parallels', 'qcow',
>              'qcow2', 'qed', 'raw', 'vdi', 'vhdx', 'vmdk', 'vpc', 'quorum' ] }
>  
>  ##
> @@ -1491,7 +1491,6 @@
>        'blkverify':  'BlockdevOptionsBlkverify',
>        'bochs':      'BlockdevOptionsGenericFormat',
>        'cloop':      'BlockdevOptionsGenericFormat',
> -      'cow':        'BlockdevOptionsGenericCOWFormat',
>        'dmg':        'BlockdevOptionsGenericFormat',
>        'parallels':  'BlockdevOptionsGenericFormat',
>        'qcow':       'BlockdevOptionsGenericCOWFormat',

Have a conflict with "[PATCH v7 0/3] block: Introduce "null" drivers" which you
applied, where these lists are sorted alphabetically.

Otherwise looks good to me.

Thanks,
Fam