All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: David L Stevens <david.stevens@oracle.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCHv5 net-next 1/3] sunvnet: upgrade to VIO protocol version 1.6
Date: Wed, 17 Sep 2014 18:36:06 -0400	[thread overview]
Message-ID: <20140917223606.GL26828@oracle.com> (raw)
In-Reply-To: <5419F3F4.9030706@oracle.com>

On (09/17/14 16:49), David L Stevens wrote:
> +	/* MTU negotiation:
> +	 *	< v1.3 - ETH_FRAME_LEN exactly
> +	 *	> v1.3 - MIN(pkt.mtu, VNET_MAX_PACKET, port->rmtu) and change
> +	 *			pkt->mtu for ACK
> +	 *	= v1.3 - ETH_FRAME_LEN + VLAN_HLEN exactly
> +	 */

Comment does not match code. Should be VNET_MAXPACKET.

Also, some general questions- 

how does this work for broadcast packets, e.g., if I do 
   "ping -b <broadcast address> -s 60000"

the 65535 MTU is only useful betwen two guests if 
inter-vnet-link is set to on, right? (i.e., can you use it when you 
go from a guest to another IP address on a different physical host)?

--Sowmini

      reply	other threads:[~2014-09-17 22:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 20:49 [PATCHv5 net-next 1/3] sunvnet: upgrade to VIO protocol version 1.6 David L Stevens
2014-09-17 22:36 ` Sowmini Varadhan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140917223606.GL26828@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=davem@davemloft.net \
    --cc=david.stevens@oracle.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.