From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUeau-0007Ns-KN for qemu-devel@nongnu.org; Thu, 18 Sep 2014 12:30:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XUeal-0000Lf-JE for qemu-devel@nongnu.org; Thu, 18 Sep 2014 12:30:08 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:34622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XUeal-0000LW-Gc for qemu-devel@nongnu.org; Thu, 18 Sep 2014 12:29:59 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Sep 2014 12:29:53 -0400 Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id E8144C90026 for ; Thu, 18 Sep 2014 12:29:41 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8IGTnKo62980324 for ; Thu, 18 Sep 2014 16:29:50 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8IGTnA7004164 for ; Thu, 18 Sep 2014 12:29:49 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <1410719879-25181-4-git-send-email-mst@redhat.com> References: <1410719879-25181-1-git-send-email-mst@redhat.com> <1410719879-25181-4-git-send-email-mst@redhat.com> Message-ID: <20140918162947.16792.44892@loki> Date: Thu, 18 Sep 2014 11:29:47 -0500 Subject: Re: [Qemu-devel] [PULL 03/12] test-qdev-global-props: Run tests on subprocess List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Eduardo Habkost , Don Slutz , Anthony Liguori Quoting Michael S. Tsirkin (2014-09-14 13:41:23) > From: Eduardo Habkost > = > There are multiple reasons for running the global property tests on a > subprocess: > = > * We need the global_props lists to be empty for each test case, so > global properties from the previous test won't affect the next one; > * We don't want the qdev_prop_check_global() warnings to pollute test > output; > * With a subprocess, we can ensure qdev_prop_check_global() is printing > the warning messages it should. > = > Signed-off-by: Eduardo Habkost > Acked-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > --- > tests/test-qdev-global-props.c | 49 ++++++++++++++++++++++++++++++++++++= ------ > 1 file changed, 43 insertions(+), 6 deletions(-) > = > diff --git a/tests/test-qdev-global-props.c b/tests/test-qdev-global-prop= s.c > index e1a1317..34223a7 100644 > --- a/tests/test-qdev-global-props.c > +++ b/tests/test-qdev-global-props.c > @@ -65,7 +65,7 @@ static const TypeInfo static_prop_type =3D { > }; > = > /* Test simple static property setting to default value */ > -static void test_static_prop(void) > +static void test_static_prop_subprocess(void) > { > MyType *mt; > = > @@ -75,8 +75,16 @@ static void test_static_prop(void) > g_assert_cmpuint(mt->prop1, =3D=3D, PROP_DEFAULT); > } > = > +static void test_static_prop(void) > +{ > + g_test_trap_subprocess("/qdev/properties/static/default/subprocess",= 0, 0); > + g_test_trap_assert_passed(); > + g_test_trap_assert_stderr(""); > + g_test_trap_assert_stdout(""); > +} > int main(int argc, char **argv) > { > g_test_init(&argc, &argv, NULL); > @@ -174,9 +200,20 @@ int main(int argc, char **argv) > type_register_static(&static_prop_type); > type_register_static(&dynamic_prop_type); > = > - g_test_add_func("/qdev/properties/static/default", test_static_prop); > - g_test_add_func("/qdev/properties/static/global", test_static_global= prop); > - g_test_add_func("/qdev/properties/dynamic/global", test_dynamic_glob= alprop); > + g_test_add_func("/qdev/properties/static/default/subprocess", > + test_static_prop_subprocess); > + g_test_add_func("/qdev/properties/static/default", > + test_static_prop); Since in the code above test_static_prop is actually the test that re-runs /qdev/properties/static/default/subprocess under g_test_trap_subprocess, ar= en't the tests (or test function implementations) backwards? > -- = > MST