All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, lcapitulino@redhat.com, famz@redhat.com,
	qemu-stable@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator
Date: Thu, 18 Sep 2014 15:19:29 -0500	[thread overview]
Message-ID: <20140918201929.19243.3680@loki> (raw)
In-Reply-To: <541A0C40.2030900@redhat.com>

Quoting Eric Blake (2014-09-17 17:33:36)
> On 09/17/2014 03:32 PM, Michael Roth wrote:
> > This more of an exercise of the dealloc visitor, where it may
> 
> s/This more/This is more/
> 
> > erroneously use an uninitialized discriminator field as indication
> > that union fields corresponding to that discriminator field/type are
> > present, which can lead to attempts to free random chunks of heap
> > memory.
> > 
> > Cc: qemu-stable@nongnu.org
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> > Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> > ---
> >  tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++
> >  tests/qapi-schema/qapi-schema-test.out  |  3 +++
> >  tests/test-qmp-input-strict.c           | 17 +++++++++++++++++
> >  3 files changed, 30 insertions(+)
> > 
> 
> R-b still stands.

Thanks, will send a v3 in a moment just to keep things clean.

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

  reply	other threads:[~2014-09-18 20:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17 21:32 [Qemu-devel] [PATCH v2 0/4] qapi: fix crash in dealloc visitor for union types Michael Roth
2014-09-17 21:32 ` [Qemu-devel] [PATCH v2 1/4] qapi: add visit_start_union and visit_end_union Michael Roth
2014-09-17 22:33   ` Eric Blake
2014-09-17 21:32 ` [Qemu-devel] [PATCH v2 2/4] qapi: dealloc visitor, implement visit_start_union Michael Roth
2014-09-17 22:27   ` Eric Blake
2014-09-17 21:32 ` [Qemu-devel] [PATCH v2 3/4] tests: add QMP input visitor test for unions with no discriminator Michael Roth
2014-09-17 22:33   ` Eric Blake
2014-09-18 20:19     ` Michael Roth [this message]
2014-09-17 21:32 ` [Qemu-devel] [PATCH v2 4/4] qemu-iotests: Test missing "driver" key for blockdev-add Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140918201929.19243.3680@loki \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.