All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Yann Droneaud <ydroneaud@opteya.com>
Cc: linux-kernel@vger.kernel.org,
	Adrian Hunter <adrian.hunter@intel.com>,
	David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	William Cohen <wcohen@redhat.com>
Subject: Re: [PATCH 0/2] perf tool: improve error handling in perf_flag_probe()
Date: Sat, 20 Sep 2014 14:14:38 +0200	[thread overview]
Message-ID: <20140920121438.GB15481@krava.brq.redhat.com> (raw)
In-Reply-To: <cover.1410595700.git.ydroneaud@opteya.com>

On Sat, Sep 13, 2014 at 10:46:22AM +0200, Yann Droneaud wrote:
> Hi,
> 
> Following the EBUSY errors reported by Jiri Olsa [1], I've tryed to
> improve a bit the way perf_flag_probe() handle errors.
> 
> In case EBUSY is returned by perf_event_open(), testing the function
> again without PERF_FLAG_FD_CLOEXEC is meaningless: EBUSY is not
> related to close-on-exec flag, so there's nothing to confirm.
> 
> For other errors, not yet handled by perf_flag_probe(), it's
> pointless to report a second error message for the same error code:
> the second check should not print an error if the error is the same
> as the one return for the first check.
> 
> [1] http://lkml.kernel.org/r/1406908014-8312-1-git-send-email-jolsa@kernel.org
> 
> Yann Droneaud (2):
>   perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY
>     error
>   perf tools: report PERF_FLAG_FD_CLOEXEC probing error once

seems good to me, for the patchset:
Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

      parent reply	other threads:[~2014-09-20 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-13  8:46 [PATCH 0/2] perf tool: improve error handling in perf_flag_probe() Yann Droneaud
2014-09-13  8:46 ` [PATCH 1/2] perf tools: shortcut PERF_FLAG_FD_CLOEXEC probing in case of EBUSY error Yann Droneaud
2014-09-13  8:46 ` [PATCH 2/2] perf tools: report PERF_FLAG_FD_CLOEXEC probing error once Yann Droneaud
2014-09-20 12:14 ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140920121438.GB15481@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=wcohen@redhat.com \
    --cc=ydroneaud@opteya.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.