From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48997)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XVz3z-00010N-Ga
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 04:33:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XVz3t-0005ww-Bj
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 04:33:39 -0400
Received: from mx1.redhat.com ([209.132.183.28]:8177)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XVz3t-0005uf-5d
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 04:33:33 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8M8XRs9015053
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Mon, 22 Sep 2014 04:33:27 -0400
Date: Mon, 22 Sep 2014 16:33:27 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20140922083327.GA6070@fam-t430.nay.redhat.com>
References: <1407303308-4615-1-git-send-email-famz@redhat.com>
	<1407303308-4615-10-git-send-email-famz@redhat.com>
	<541BF77C.3090808@redhat.com>
	<20140922055607.GA19858@fam-t430.nay.redhat.com>
	<541FD947.2080302@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <541FD947.2080302@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v2 09/10] virtio-scsi-dataplane: Code
 to run virtio-scsi on iothread
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, 09/22 10:09, Paolo Bonzini wrote:
> Il 22/09/2014 07:56, Fam Zheng ha scritto:
> >> > 
> >> > Please add these to VirtIOSCSI rather than VirtIOSCSICommon.  Same for
> >> > the new functions you declare below.
> > What's the rationale, please? Asking because especially the VirtIOSCSIVring
> > fields are the dataplane counterparts of VirtQueue fields, so putting in
> > VirtIOSCSI seems unnatural for me.
> 
> Because everything you put in VirtIOSCSICommon will be shared between
> virtio-scsi and vhost-scsi, and vhost-scsi need not use neither vring
> nor dataplane.
> 

I see, I'll move it into VirtIOSCSI then!

Fam