From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755139AbaIWJ6U (ORCPT ); Tue, 23 Sep 2014 05:58:20 -0400 Received: from casper.infradead.org ([85.118.1.10]:59886 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754978AbaIWJ6T (ORCPT ); Tue, 23 Sep 2014 05:58:19 -0400 Date: Tue, 23 Sep 2014 11:58:15 +0200 From: Peter Zijlstra To: Andi Kleen Cc: Andi Kleen , linux-kernel@vger.kernel.org, mingo@kernel.org, eranian@google.com, tglx@linutronix.de Subject: Re: [PATCH 2/2] perf, x86: Use INTEL_FLAGS_UEVENT_CONSTRAINT for PRECDIST Message-ID: <20140923095815.GA6179@worktop.ger.corp.intel.com> References: <1410310148-26260-1-git-send-email-andi@firstfloor.org> <1410310148-26260-2-git-send-email-andi@firstfloor.org> <20140910075926.GM6758@twins.programming.kicks-ass.net> <20140910140258.GI5387@tassilo.jf.intel.com> <20140910142232.GC4783@worktop.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140910142232.GC4783@worktop.ger.corp.intel.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 10, 2014 at 04:22:32PM +0200, Peter Zijlstra wrote: > On Wed, Sep 10, 2014 at 07:02:58AM -0700, Andi Kleen wrote: > > On Wed, Sep 10, 2014 at 09:59:26AM +0200, Peter Zijlstra wrote: > > > On Tue, Sep 09, 2014 at 05:49:08PM -0700, Andi Kleen wrote: > > > > From: Andi Kleen > > > > > > > > The earlier commit 86a04461a made near all PEBS on > > > > Sandy/IvyBridge/Haswell to reject non zero flags. > > > > > > What's magic about nehalem and westmere? > > > > I wasn't able to confirm their behavior explicitly, so I felt > > it best to leave them alone. > > > > But in principle adding the _FLAGS changes there too would > > make sense too. > > Yeah please do that patch ASAP, having PEBS behave differently across > uarchs is wrong. Ping!