All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francois Romieu <romieu@fr.zoreil.com>
To: Mark Einon <mark.einon@gmail.com>
Cc: Tobias Klauser <tklauser@distanz.ch>,
	gregkh@linuxfoundation.org, davem@davemloft.net,
	devel@driverdev.osuosl.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net
Date: Tue, 23 Sep 2014 21:02:42 +0200	[thread overview]
Message-ID: <20140923190242.GA8096@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20140923094614.GA5130@leicester.auvation.com>

Mark Einon <mark.einon@gmail.com> :
[...]
> > No need for the #define here, just assigne et131x_pm_ops to .driver.pm
> > directly, its members will be NULL and thus never called. Also, you can
> > make et131x_pm_ops const.
> 
> Ok, I can change this.
> 
> Btw, this appears to be a fairly standard way of using .driver.pm among
> ethernet drivers, e.g. see 3com/3c59x.c, atheros, marvell... - perhaps
> there is a case for changing all instances of this code?

How about kernel tinification ?

-- 
Ueimor

  parent reply	other threads:[~2014-09-23 19:03 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-22 21:28 [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Mark Einon
2014-09-22 23:56 ` Angus Gibson
2014-09-23  9:51   ` Mark Einon
2014-09-23  9:51     ` Mark Einon
2014-09-23  1:57 ` Joe Perches
2014-09-23  9:50   ` Mark Einon
2014-09-23  9:50     ` Mark Einon
2014-09-23  7:22 ` Tobias Klauser
2014-09-23  7:22   ` Tobias Klauser
2014-09-23  9:46   ` Mark Einon
2014-09-23  9:46     ` Mark Einon
2014-09-23 10:01     ` Tobias Klauser
2014-09-23 10:01       ` Tobias Klauser
2014-09-23 11:06       ` Mark Einon
2014-09-23 11:06         ` Mark Einon
2014-09-23 19:41       ` [PATCH 1/4] staging: et131x: zero allocation of fbr to prevent random address access Mark Einon
2014-09-23 19:41         ` Mark Einon
2014-09-23 19:41         ` [PATCH 2/4] staging: et131x: don't cast a void* to a struct pointer Mark Einon
2014-09-23 19:41           ` Mark Einon
2014-09-23 19:41         ` [PATCH 3/4] staging: et131x: Add space after { in pci ID table Mark Einon
2014-09-23 19:41           ` Mark Einon
2014-09-23 19:41         ` [PATCH 4/4] staging: et131x: Remove unnecessary defines to enable driver PM Mark Einon
2014-09-23 19:41           ` Mark Einon
2014-09-23 19:02     ` Francois Romieu [this message]
2014-09-23 19:17       ` [RFC PATCH linux-next] et131x: Promote staging et131x driver to drivers/net Joe Perches
2014-09-23 20:07         ` Francois Romieu
2014-09-23 20:07           ` Francois Romieu
2014-09-23 20:05 ` [PATCH v2] " Mark Einon
2014-09-23 20:05   ` Mark Einon
2014-09-23 21:07   ` Joe Perches
2014-09-23 21:07     ` Joe Perches
2014-09-24  8:54     ` [PATCH 1/4] staging: et131x: Use ether_addr_copy when copying ethernet addresses Mark Einon
2014-09-24  8:54       ` Mark Einon
2014-09-24  8:54       ` [PATCH 2/4] staging: et131x: Cat some lines less than 80 columns Mark Einon
2014-09-24  8:54         ` Mark Einon
2014-09-24  8:54       ` [PATCH 3/4] staging: et131x: Remove unnecessary OOM message Mark Einon
2014-09-24  8:54         ` Mark Einon
2014-09-24  8:54       ` [PATCH 4/4] staging: et131x: Remove unnecessary parentheses Mark Einon
2014-09-24  8:54         ` Mark Einon
2014-09-24  9:00     ` [PATCH v2] et131x: Promote staging et131x driver to drivers/net Mark Einon
2014-09-24  9:00       ` Mark Einon
  -- strict thread matches above, loose matches on Subject: below --
2013-01-18 20:40 [RFC PATCH linux-next] " Mark Einon
2013-01-18 22:57 ` Greg KH
2013-01-19 11:03   ` Dan Carpenter
2013-01-21 23:44     ` Mark Einon
2013-01-22  6:20       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140923190242.GA8096@electric-eye.fr.zoreil.com \
    --to=romieu@fr.zoreil.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.einon@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.