From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmhZ-0006L8-Kw for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:33:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWmhS-0000tj-9F for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:33:49 -0400 Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]:46495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWmhS-0000lQ-3Z for qemu-devel@nongnu.org; Wed, 24 Sep 2014 09:33:42 -0400 Received: by mail-we0-f175.google.com with SMTP id u57so5407546wes.34 for ; Wed, 24 Sep 2014 06:33:36 -0700 (PDT) Date: Wed, 24 Sep 2014 14:33:33 +0100 From: Stefan Hajnoczi Message-ID: <20140924133333.GA14194@stefanha-thinkpad.redhat.com> References: <20140825111951.31112.50251.stgit@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <20140825111951.31112.50251.stgit@fimbulvetr.bsc.es> Subject: Re: [Qemu-devel] [PATCH v4 0/2] trace: Trace control commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?iso-8859-1?Q?Llu=EDs?= Vilanova Cc: Luiz Capitulino , qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster --KsGdsel6WgEHnImy Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 25, 2014 at 01:19:51PM +0200, Llu=EDs Vilanova wrote: > Adds QAPI/QMP commands to control tracing events, and reimplements some o= f the > related HMP commands on top. >=20 > NOTE: The "trace-event-set-state" command uses a bool 'enable' argument i= nstead > of an enum 'state'. I'm still not sure if an enum is better than th= e two > separate booleans. >=20 > Signed-off-by: Llu=EDs Vilanova > --- >=20 > Changes in v4: >=20 > * Split QAPI/QMP and HMP changes into separate patches. > * Add copyright information in QAPI file (Eric Blake). > * Replace event state booleans with an enum (Eric Blake). > * Document pattern type for argument "name" (Eric Blake). > * Other documentation improvements (Markus Armbruster). > * Change "keepgoing" to "ignore-unavailable" (Markus Armbruster). > * Add examples in QMP command definition file (Eric Blake). > * Propagate QMP errors to HMP (Markus Armbruster, Stefan Hajnoczi). > * Remove trailing newlines when using error_setg (Stefan Hajnoczi). > * Avoid multiple invocations of error_setg (Stefan Hajnoczi). > * Various cosmetic changes (Markus Armbruster). Sorry for the long wait. I am merging it now. The only thing I wonder about is adding trace/qmp.o to util-obj-y. But I've built QEMU from scratch also for Windows and the build completes successfully. I was worried that a utility like qemu-img might not have the necessary headers or objects for QMP code but it seems to work. If there are issues we can still fix it later in the 2.2 release cycle. Thanks, applied to my tracing tree: https://github.com/stefanha/qemu/commits/tracing Stefan --KsGdsel6WgEHnImy Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUIsgtAAoJEJykq7OBq3PI5aoIAKYRJMXp2z9FSyKR2ev56WrN TVFeukldcval9MunWrsCidVJoEfxBQXIuNpky3osfTBTxVNqUQnxdibRISuYvgay NU97XvKhMO8CAb8mufd2xvzWPf9RayFx2lpzCRdT+PadZfMplcvsob69S6V+zjyY XoDcZCkeR1F9J2hKp/nM1XD1c4ns3U0DXjvRCwVGfoPbSmuCyvpvLTx/YF4/WHH2 yxGIhcFH97nCwa5q+8zBambBcxzYLavv0kRZcSlzvq0oh77E9Kge+02WxseywhOm UzY1HN75/LcdDWEBGdTHPlRYRA4RklNtjlRk8sTV6tdxOAnwpiJPySqFW8a8Mpk= =cBbf -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy--