From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbaIYTzA (ORCPT ); Thu, 25 Sep 2014 15:55:00 -0400 Received: from top.free-electrons.com ([176.31.233.9]:60973 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751875AbaIYTy6 (ORCPT ); Thu, 25 Sep 2014 15:54:58 -0400 Date: Thu, 25 Sep 2014 21:54:54 +0200 From: Antoine Tenart To: Arnd Bergmann Cc: linux-arm-kernel@lists.infradead.org, Antoine Tenart , sebastian.hesselbarth@gmail.com, Peter.Chen@freescale.com, balbi@ti.com, p.zabel@pengutronix.de, thomas.petazzoni@free-electrons.com, zmxu@marvell.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, alexandre.belloni@free-electrons.com, jszhang@marvell.com Subject: Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx Message-ID: <20140925195454.GA6074@kwain> References: <1411468088-5702-1-git-send-email-antoine.tenart@free-electrons.com> <1411468088-5702-8-git-send-email-antoine.tenart@free-electrons.com> <201409252112.07513.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201409252112.07513.arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd, On Thu, Sep 25, 2014 at 09:12:07PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014, Antoine Tenart wrote: > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > + struct ci_hdrc_platform_data *ci_pdata) > > +{ > > + ci_pdata->phy = of_phy_get(dev->of_node, 0); > > FWIW, I accidentally built a kernel with this driver enabled and got a warning > for this code. The problem is that ci_pdata->phy is a 'struct usb_phy' pointer, > while of_phy_get() returns a generic 'struct phy'. While the two have similar > behavior, they are not the same thing and this can't work. That's because this series applies on top of: https://lkml.org/lkml/2014/9/15/141 Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Antoine Tenart Subject: Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx Date: Thu, 25 Sep 2014 21:54:54 +0200 Message-ID: <20140925195454.GA6074@kwain> References: <1411468088-5702-1-git-send-email-antoine.tenart@free-electrons.com> <1411468088-5702-8-git-send-email-antoine.tenart@free-electrons.com> <201409252112.07513.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <201409252112.07513.arnd-r2nGTMty4D4@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Antoine Tenart , sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org List-Id: devicetree@vger.kernel.org Arnd, On Thu, Sep 25, 2014 at 09:12:07PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014, Antoine Tenart wrote: > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > + struct ci_hdrc_platform_data *ci_p= data) > > +{ > > + ci_pdata->phy =3D of_phy_get(dev->of_node, 0); >=20 > FWIW, I accidentally built a kernel with this driver enabled and got = a warning > for this code. The problem is that ci_pdata->phy is a 'struct usb_phy= ' pointer, > while of_phy_get() returns a generic 'struct phy'. While the two have= similar > behavior, they are not the same thing and this can't work. That's because this series applies on top of: https://lkml.org/lkml/2014/9/15/141 Antoine --=20 Antoine T=E9nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: antoine.tenart@free-electrons.com (Antoine Tenart) Date: Thu, 25 Sep 2014 21:54:54 +0200 Subject: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx In-Reply-To: <201409252112.07513.arnd@arndb.de> References: <1411468088-5702-1-git-send-email-antoine.tenart@free-electrons.com> <1411468088-5702-8-git-send-email-antoine.tenart@free-electrons.com> <201409252112.07513.arnd@arndb.de> Message-ID: <20140925195454.GA6074@kwain> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Arnd, On Thu, Sep 25, 2014 at 09:12:07PM +0200, Arnd Bergmann wrote: > On Tuesday 23 September 2014, Antoine Tenart wrote: > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > + struct ci_hdrc_platform_data *ci_pdata) > > +{ > > + ci_pdata->phy = of_phy_get(dev->of_node, 0); > > FWIW, I accidentally built a kernel with this driver enabled and got a warning > for this code. The problem is that ci_pdata->phy is a 'struct usb_phy' pointer, > while of_phy_get() returns a generic 'struct phy'. While the two have similar > behavior, they are not the same thing and this can't work. That's because this series applies on top of: https://lkml.org/lkml/2014/9/15/141 Antoine -- Antoine T?nart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com