Re: [PATCH v6 for-4.5 3/5] xl: add 'xstrdup' next to 'xrealloc'

From: Wei Liu <wei.liu2@citrix.com>
To: David Scott <dave.scott@citrix.com>
Cc: xen-devel@lists.xenproject.org, ian.campbell@citrix.com,
	ian.jackson@eu.citrix.com, wei.liu2@citrix.com,
	stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v6 for-4.5 3/5] xl: add 'xstrdup' next to 'xrealloc'
Date: Fri, 26 Sep 2014 10:22:17 +0100	[thread overview]
Message-ID: <20140926092217.GC12753@zion.uk.xensource.com> (raw)
In-Reply-To: <1411591685-25308-4-git-send-email-dave.scott@citrix.com>

On Wed, Sep 24, 2014 at 09:48:03PM +0100, David Scott wrote:
> Signed-off-by: David Scott <dave.scott@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

> ---
>  tools/libxl/xl_cmdimpl.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 1695f74..1fc2171 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -300,6 +300,19 @@ static void *xrealloc(void *ptr, size_t sz) {
>      return r;
>  }
>  
> +static char *xstrdup(const char *x) __attribute__ ((unused));
> +static char *xstrdup(const char *x)
> +{
> +    char *r;
> +    r = strdup(x);
> +    if (!r) {
> +        fprintf(stderr, "xl: Unable to strdup a string of length %zu.\n",
> +                strlen(x));
> +        exit(-ERROR_FAIL);
> +    }
> +    return r;
> +}
> +
>  #define ARRAY_EXTEND_INIT(array,count,initfn)                           \
>      ({                                                                  \
>          typeof((count)) array_extend_old_count = (count);               \
> -- 
> 1.7.10.4