From: Matt Fleming <matt@console-pimps.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Paul Bolle <pebolle@tiscali.nl>,
Linus Torvalds <torvalds@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Leif Lindholm <leif.lindholm@linaro.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [GIT PULL] EFI urgent fixes
Date: Fri, 26 Sep 2014 13:24:05 +0100 [thread overview]
Message-ID: <20140926122405.GW18635@console-pimps.org> (raw)
In-Reply-To: <20140926113510.GA14625@gmail.com>
On Fri, 26 Sep, at 01:35:10PM, Ingo Molnar wrote:
>
> A delta fix would be nice at this point, I've got the x86 side
> tested and besides this build bug it's ready to go to Linus.
Given that the typo doesn't result in an actual build failure, do you
still want the following delta fix?
---
>From 7d4354dc767ba11d1555d27596a3dd3426eb3354 Mon Sep 17 00:00:00 2001
From: Matt Fleming <matt.fleming@intel.com>
Date: Fri, 26 Sep 2014 13:11:05 +0100
Subject: [PATCH] efi: Fix CONFIG_EFI_ARMSTUB typo for building libstub
commit 84be880560fb ("Revert "efi/x86: efistub: Move shared dependencies
to <asm/efi.h>"") introduced a typo into drivers/firmware/efi/Makefile
where CONFIG_EFI_ARM_STUB should instead be CONFIG_EFI_ARMSTUB.
The typo doesn't result in an actual build failure and was found with
Paul's "800 line perl monster" in linux-next.
The reason that we don't see a build failure is because arm64 (which is
now the only user of libstub) already includes logic to build libstub
from arch/arm64/Makefile.
Correct the typo anyway.
Reported-by: Paul Bolle <pebolle@tiscali.nl>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
---
drivers/firmware/efi/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile
index aef6a95adef5..5b0d892a01c0 100644
--- a/drivers/firmware/efi/Makefile
+++ b/drivers/firmware/efi/Makefile
@@ -7,4 +7,4 @@ obj-$(CONFIG_EFI_VARS_PSTORE) += efi-pstore.o
obj-$(CONFIG_UEFI_CPER) += cper.o
obj-$(CONFIG_EFI_RUNTIME_MAP) += runtime-map.o
obj-$(CONFIG_EFI_RUNTIME_WRAPPERS) += runtime-wrappers.o
-obj-$(CONFIG_EFI_ARM_STUB) += libstub/
+obj-$(CONFIG_EFI_ARMSTUB) += libstub/
--
1.9.3
--
Matt Fleming, Intel Open Source Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Leif Lindholm
<leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [GIT PULL] EFI urgent fixes
Date: Fri, 26 Sep 2014 13:24:05 +0100 [thread overview]
Message-ID: <20140926122405.GW18635@console-pimps.org> (raw)
In-Reply-To: <20140926113510.GA14625-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Fri, 26 Sep, at 01:35:10PM, Ingo Molnar wrote:
>
> A delta fix would be nice at this point, I've got the x86 side
> tested and besides this build bug it's ready to go to Linus.
Given that the typo doesn't result in an actual build failure, do you
still want the following delta fix?
---
>From 7d4354dc767ba11d1555d27596a3dd3426eb3354 Mon Sep 17 00:00:00 2001
From: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Date: Fri, 26 Sep 2014 13:11:05 +0100
Subject: [PATCH] efi: Fix CONFIG_EFI_ARMSTUB typo for building libstub
commit 84be880560fb ("Revert "efi/x86: efistub: Move shared dependencies
to <asm/efi.h>"") introduced a typo into drivers/firmware/efi/Makefile
where CONFIG_EFI_ARM_STUB should instead be CONFIG_EFI_ARMSTUB.
The typo doesn't result in an actual build failure and was found with
Paul's "800 line perl monster" in linux-next.
The reason that we don't see a build failure is because arm64 (which is
now the only user of libstub) already includes logic to build libstub
from arch/arm64/Makefile.
Correct the typo anyway.
Reported-by: Paul Bolle <pebolle-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
Signed-off-by: Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/firmware/efi/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile
index aef6a95adef5..5b0d892a01c0 100644
--- a/drivers/firmware/efi/Makefile
+++ b/drivers/firmware/efi/Makefile
@@ -7,4 +7,4 @@ obj-$(CONFIG_EFI_VARS_PSTORE) += efi-pstore.o
obj-$(CONFIG_UEFI_CPER) += cper.o
obj-$(CONFIG_EFI_RUNTIME_MAP) += runtime-map.o
obj-$(CONFIG_EFI_RUNTIME_WRAPPERS) += runtime-wrappers.o
-obj-$(CONFIG_EFI_ARM_STUB) += libstub/
+obj-$(CONFIG_EFI_ARMSTUB) += libstub/
--
1.9.3
--
Matt Fleming, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-09-26 12:24 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 7:31 [GIT PULL] EFI urgent fixes Matt Fleming
2014-09-25 14:41 ` Ingo Molnar
2014-09-25 14:41 ` Ingo Molnar
2014-09-25 14:44 ` Matt Fleming
2014-09-25 14:44 ` Matt Fleming
2014-09-26 11:27 ` Paul Bolle
2014-09-26 11:27 ` Paul Bolle
2014-09-26 11:35 ` Ingo Molnar
2014-09-26 11:35 ` Ingo Molnar
2014-09-26 12:24 ` Matt Fleming [this message]
2014-09-26 12:24 ` Matt Fleming
2014-09-27 5:49 ` Ingo Molnar
2014-09-27 5:49 ` Ingo Molnar
2014-09-26 11:44 ` Matt Fleming
2014-09-26 11:44 ` Matt Fleming
2014-09-26 11:59 ` Paul Bolle
2014-09-26 11:59 ` Paul Bolle
2014-09-26 12:34 ` Matt Fleming
2014-09-26 12:34 ` Matt Fleming
2014-09-26 12:55 ` Paul Bolle
2014-09-27 8:04 ` Valentin Rothberg
2014-09-27 8:04 ` Valentin Rothberg
2014-09-27 9:59 ` Paul Bolle
2014-09-27 9:59 ` Paul Bolle
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 21:06 Matt Fleming
2015-07-31 7:56 ` Ingo Molnar
2015-07-31 7:56 ` Ingo Molnar
2015-05-05 16:27 Matt Fleming
2015-05-06 6:31 ` Ingo Molnar
2015-05-06 6:31 ` Ingo Molnar
2015-03-02 12:51 Matt Fleming
2015-03-02 13:24 ` Ingo Molnar
2015-03-02 13:24 ` Ingo Molnar
2015-03-02 13:35 ` Matt Fleming
2015-02-18 11:55 Matt Fleming
2015-02-18 11:55 ` Matt Fleming
2015-02-18 13:43 ` Ingo Molnar
2015-02-18 13:43 ` Ingo Molnar
2015-02-18 16:36 ` Ard Biesheuvel
2015-02-18 16:36 ` Ard Biesheuvel
2015-02-18 16:57 ` Ingo Molnar
2015-02-18 16:57 ` Ingo Molnar
2014-09-08 21:55 Matt Fleming
2014-09-08 21:55 ` Matt Fleming
2014-09-09 5:07 ` Ingo Molnar
2014-09-09 5:07 ` Ingo Molnar
2014-09-09 7:07 ` Matt Fleming
2014-09-09 7:07 ` Matt Fleming
2014-09-09 14:55 ` Ingo Molnar
2014-08-22 7:52 Matt Fleming
2014-08-22 7:52 ` Matt Fleming
2014-08-22 8:15 ` Ingo Molnar
2014-08-22 8:15 ` Ingo Molnar
2014-07-14 12:54 Matt Fleming
2014-07-14 12:54 ` Matt Fleming
2014-06-27 14:51 Matt Fleming
2014-06-27 14:51 ` Matt Fleming
2014-06-04 16:53 Matt Fleming
2014-06-04 16:53 ` Matt Fleming
2014-04-11 7:16 Matt Fleming
2014-04-11 7:16 ` Matt Fleming
2014-04-11 8:27 ` Ingo Molnar
2014-04-11 8:27 ` Ingo Molnar
2014-02-14 13:08 Matt Fleming
2014-02-14 13:08 ` Matt Fleming
2013-11-29 12:09 Matt Fleming
2013-11-29 12:09 ` Matt Fleming
2013-07-11 11:16 Matt Fleming
2013-07-11 11:16 ` Matt Fleming
2013-06-07 11:50 Matt Fleming
2013-06-07 11:50 ` Matt Fleming
2013-06-10 21:36 ` Matt Fleming
2013-06-10 21:36 ` Matt Fleming
2013-05-17 10:18 Matt Fleming
2013-05-17 10:18 ` Matt Fleming
2013-04-25 8:49 Matt Fleming
2013-04-25 8:49 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140926122405.GW18635@console-pimps.org \
--to=matt@console-pimps.org \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pebolle@tiscali.nl \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.