From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXT8y-0008Ow-2E for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:53:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXT8p-0003ss-1E for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:52:56 -0400 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:46586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXT8o-0003rt-OP for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:52:46 -0400 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 26 Sep 2014 11:52:40 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 69DF217D8059 for ; Fri, 26 Sep 2014 11:54:46 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s8QAqcdl4522220 for ; Fri, 26 Sep 2014 10:52:38 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s8QAqb2d030957 for ; Fri, 26 Sep 2014 04:52:38 -0600 Date: Fri, 26 Sep 2014 12:52:36 +0200 From: Cornelia Huck Message-ID: <20140926125236.0c7ca9f4.cornelia.huck@de.ibm.com> In-Reply-To: <1411723721-20484-24-git-send-email-imammedo@redhat.com> References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> <1411723721-20484-24-git-send-email-imammedo@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: mst@redhat.com, amit.shah@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com, kraxel@redhat.com, dmitry@daynix.com, pbonzini@redhat.com, rth@twiddle.net On Fri, 26 Sep 2014 09:28:28 +0000 Igor Mammedov wrote: > s390-sclp-event-facility creates s390-sclp-events-bus > and immeadiatly sets its allow_hotplug field to 0, > which is NOP since it's already 0 by default. > > Also since BUS is not hotpluggable, it's not possible > to call SCLP_EVENT{ DeviceClass.unplug } callback > from qdev_unplug() making this unreachable code, > so drop it as well. > > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini > --- > hw/s390x/event-facility.c | 2 -- > 1 file changed, 2 deletions(-) Reviewed-by: Cornelia Huck