All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: ian.campbell@citrix.com, wency@cn.fujitsu.com,
	Jiang Yunhong <yunhong.jiang@intel.com>,
	eddie.dong@intel.com, xen-devel@lists.xen.org,
	rshriram@cs.ubc.ca, Yang Hongyang <yanghy@cn.fujitsu.com>,
	laijs@cn.fujitsu.com
Subject: Re: [PATCH for-4.5 v20 07/12] xl/remus: change bool to defbool
Date: Fri, 26 Sep 2014 10:02:13 -0400	[thread overview]
Message-ID: <20140926140213.GH30097@laptop.dumpdata.com> (raw)
In-Reply-To: <21540.42889.978272.747892@mariner.uk.xensource.com>

On Fri, Sep 26, 2014 at 12:38:49AM +0100, Ian Jackson wrote:
> Shriram Rajagopalan writes ("Re: [Xen-devel] [PATCH for-4.5 v20 07/12] xl/remus: change bool to defbool"):
> > On Sep 25, 2014 3:21 PM, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
> > wrote:
> > > On Thu, Sep 25, 2014 at 02:16:19PM +0800, Yang Hongyang wrote:
> > > > Use defbool instead of bool for boolean flags in remus_info struct.
> > >
> > > While that change by itself looks OK, the change in 'libxl_types.idl'
> > > break the ABI.
> 
> (We don't provide ABI stability in libxl (across Xen releases), only
> API stability.  However, this change does break the API too:)
> 
> > > Could you say a bit of why that is OK? As in, would there had
> > > been in the past any users of this ABI that now would have issues with this?
> >
> > There were no users of the libxl Remus api in the past. Certainly not an API
> > level user like libvirt.
> 
> This is IMO a good answer.  As I said earlier, the libxl Remus API in
> previous version does not really work properly so it seems unlikely
> that this change will break any uses.
> 
> > > Also, how important is this patch? Does it have to go in or
> > > can it be dropped from the patchset?
> > 
> > Well, this defbool thing came up as part of the feedback.
> 
> Ian C and I think that this variable should be a defbool.  That it
> wasn't, beforehand, was a mistake.  We have an opportinity to fix that
> now, but we won't after 4.5 if we release working libxl Remus support
> in 4.5 (as we intend.)

OK, defbool it is. Thank you for clearing that up.

  reply	other threads:[~2014-09-26 14:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-25  6:16 [PATCH for-4.5 v20 00/12] Remus/Libxl: Remus network buffering and drbd disk Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 01/12] libxl: introduce libxl__multidev_prepare_with_aodev Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 02/12] libxl: Extend libxl__ao_device with a libxl__ev_child member Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 03/12] autoconf: add libnl3 dependency for Remus network buffering support Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 04/12] libxl/remus: introduce an abstract Remus device layer Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 05/12] libxl/remus: setup and control network output buffering Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 06/12] libxl/remus: setup and control disk replication for DRBD backends Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 07/12] xl/remus: change bool to defbool Yang Hongyang
2014-09-25 19:21   ` Konrad Rzeszutek Wilk
2014-09-25 20:03     ` Shriram Rajagopalan
2014-09-25 23:38       ` Ian Jackson
2014-09-26 14:02         ` Konrad Rzeszutek Wilk [this message]
2014-09-25  6:16 ` [PATCH for-4.5 v20 08/12] xl/remus: cmdline switch to explicitly enable unsafe configurations Yang Hongyang
2014-09-25 19:23   ` Konrad Rzeszutek Wilk
2014-09-25  6:16 ` [PATCH for-4.5 v20 09/12] xl/remus: cmdline switches and config vars to control network buffering Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 10/12] xl/remus: add a cmdline switch to disable disk replication Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 11/12] libxl/remus: add LIBXL_HAVE_REMUS to indicate Remus support in libxl Yang Hongyang
2014-09-25  6:16 ` [PATCH for-4.5 v20 12/12] MAINTAINERS: update maintained files of Remus Yang Hongyang
2014-09-25 19:24   ` Konrad Rzeszutek Wilk
2014-09-25 19:28 ` [PATCH for-4.5 v20 00/12] Remus/Libxl: Remus network buffering and drbd disk Konrad Rzeszutek Wilk
2014-09-26  5:40   ` Hongyang Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140926140213.GH30097@laptop.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=eddie.dong@intel.com \
    --cc=ian.campbell@citrix.com \
    --cc=laijs@cn.fujitsu.com \
    --cc=rshriram@cs.ubc.ca \
    --cc=wency@cn.fujitsu.com \
    --cc=xen-devel@lists.xen.org \
    --cc=yanghy@cn.fujitsu.com \
    --cc=yunhong.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.