From: Stephen Hemminger <stephen@networkplumber.org>
To: Vadim Kochan <vadim4j@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ip monitor: Changed 'Unknown message' format to be more informative
Date: Sun, 28 Sep 2014 16:15:51 -0700 [thread overview]
Message-ID: <20140928161551.32f0034b@urahara> (raw)
In-Reply-To: <1410891830-4556-1-git-send-email-vadim4j@gmail.com>
On Tue, 16 Sep 2014 21:23:50 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:
> In case if unknown message was handled then it will be displayed as:
>
> Unknown message: type=0x00000044(68) flags=0x00000000(0) len=0x0000004c(76)
>
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
> ---
> ip/ipmonitor.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c
> index 70f2a7a..838934d 100644
> --- a/ip/ipmonitor.c
> +++ b/ip/ipmonitor.c
> @@ -135,8 +135,10 @@ static int accept_msg(const struct sockaddr_nl *who,
> return 0;
> if (n->nlmsg_type != NLMSG_ERROR && n->nlmsg_type != NLMSG_NOOP &&
> n->nlmsg_type != NLMSG_DONE) {
> - fprintf(fp, "Unknown message: %08x %08x %08x\n",
> - n->nlmsg_len, n->nlmsg_type, n->nlmsg_flags);
> + fprintf(fp, "Unknown message: type=0x%08x(%d) flags=0x%08x(%d)"
> + "len=0x%08x(%d)\n", n->nlmsg_type, n->nlmsg_type,
> + n->nlmsg_flags, n->nlmsg_flags, n->nlmsg_len,
> + n->nlmsg_len);
> }
> return 0;
> }
Patch is formatted improperly, it should be indented only with tabs.
prev parent reply other threads:[~2014-09-28 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 18:23 [PATCH iproute2] ip monitor: Changed 'Unknown message' format to be more informative Vadim Kochan
2014-09-28 23:15 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140928161551.32f0034b@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.