From: Baoquan He <bhe@redhat.com>
To: Michael Holzheu <holzheu@linux.vnet.ibm.com>
Cc: kexec@lists.infradead.org, kumagai-atsushi@mxc.nes.nec.co.jp
Subject: Re: Add "--mem-usage" support for s390x
Date: Mon, 29 Sep 2014 17:04:32 +0800 [thread overview]
Message-ID: <20140929090432.GA9989@dhcp-16-116.nay.redhat.com> (raw)
In-Reply-To: <20140926133441.5e58303c@holzheu>
On 09/26/14 at 01:34pm, Michael Holzheu wrote:
> On Fri, 26 Sep 2014 16:55:46 +0800
> > > Isn't this a chicken-and-egg problem? In order to determine vmalloc start
> > > I have to be able to read memory. But in order to read memory I have
> > > to call get_kcore_dump_loads() first.
> > >
> > > What about using /proc/iomem to find out if an address is a real address?
> >
> > Well, that's good it works for s390. Anyway in get_kcore_dump_loads() it
> > just gets the physical ram region, and filter out the unwanted region,
> > so your method is good. In x86_64, the is_vmalloc_addr_x86_64 is not
> > only filtering the vmalloc, but vmmemmap and modules_vaadr region. For
> > simplicity it's only named as is_vmalloc_addr.
>
> Not sure if I understood, why ths is_real_addr() function does not
> work for x86_64.
>
> Also for x86 all three areas, vmalloc, vmemmap, and modules_vaddr, are
> virtual memory regions with addresses outside of the the memory ranges
> where /proc/iommem reports physical memory, right?
>
> So the new is_real_addr() function should return false for that areas.
is_real_addr() should work for x86_64, this almost does the way
kexec-tools is doing. Originally I just consider this for x86_64,
skipped other ARCHs. From x86_64 point of view, processing kcore only
need to pick up the program segments we want. If it's hard to handle it,
I am fine with it that you use the is_real_addr to do it. But please
don't use this name, it could be is_phy_addr() or somthing like that.
Please post your patch and test x86_64 too and we can review it.
In fact the other way is wrapping your is_real_addr() to
is_vmalloc_addr_s390(), and make it work for s390. If later other ARCH
also has this requirements, raise it to be common function. Anyway it's
fine to me if it can work.
Thanks
Baoquan
>
> Michael
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2014-09-29 9:05 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 3:15 [PATCH v6 0/8] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-09-01 3:15 ` [PATCH v6 1/8] initialize pfn_memhole in get_num_dumpable_cyclic Baoquan He
2014-09-01 3:15 ` [PATCH v6 2/8] functions to get crashkernel memory range Baoquan He
2014-09-01 3:15 ` [PATCH v6 3/8] preparation functions for parsing vmcoreinfo Baoquan He
2014-09-01 3:15 ` [PATCH v6 4/8] set vmcoreinfo for kcore Baoquan He
2014-09-01 3:15 ` [PATCH v6 5/8] prepare the dump loads for kcore analysis Baoquan He
2014-09-01 3:15 ` [PATCH v6 6/8] introduce a function exclude_zero_pages_cyclic() Baoquan He
2014-09-01 3:15 ` [PATCH v6 7/8] implement a function to print the memory usage Baoquan He
2014-09-01 3:15 ` [PATCH v6 8/8] add a new interface to show the memory usage of 1st kernel Baoquan He
2014-09-02 11:52 ` Vivek Goyal
2014-09-02 13:15 ` Baoquan He
2014-09-02 13:24 ` Baoquan He
2014-09-03 8:18 ` Atsushi Kumagai
2014-09-03 8:21 ` bhe
2014-09-02 6:20 ` [PATCH v6 0/8] " Atsushi Kumagai
2014-09-02 6:38 ` bhe
2014-09-22 15:02 ` Add "--mem-usage" support for s390x Michael Holzheu
2014-09-23 2:40 ` Baoquan He
2014-09-23 2:48 ` Baoquan He
2014-09-23 2:58 ` Baoquan He
2014-09-24 15:19 ` Michael Holzheu
2014-09-25 9:44 ` Baoquan He
2014-09-26 8:10 ` Michael Holzheu
2014-09-26 8:55 ` Baoquan He
2014-09-26 9:14 ` Baoquan He
2014-09-26 11:34 ` Michael Holzheu
2014-09-29 9:04 ` Baoquan He [this message]
2014-09-29 13:12 ` Michael Holzheu
2014-09-29 13:14 ` [PATCH] makedumpfile: Enable --mem-usage " Michael Holzheu
2014-09-30 9:02 ` Baoquan He
2014-10-01 16:59 ` Michael Holzheu
2014-10-09 6:41 ` Atsushi Kumagai
2014-10-10 12:23 ` Michael Holzheu
2014-10-14 7:19 ` Atsushi Kumagai
2014-10-14 7:28 ` bhe
2014-10-14 7:42 ` bhe
2014-10-16 12:37 ` Michael Holzheu
2014-10-23 6:56 ` Atsushi Kumagai
2014-10-23 10:30 ` Michael Holzheu
2014-10-30 1:29 ` Atsushi Kumagai
2014-10-30 9:14 ` Michael Holzheu
2014-10-31 5:25 ` Atsushi Kumagai
2014-10-27 7:57 ` bhe
2014-10-27 9:04 ` bhe
2014-10-28 4:34 ` Atsushi Kumagai
2014-10-28 4:34 ` Atsushi Kumagai
2014-10-28 4:46 ` bhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140929090432.GA9989@dhcp-16-116.nay.redhat.com \
--to=bhe@redhat.com \
--cc=holzheu@linux.vnet.ibm.com \
--cc=kexec@lists.infradead.org \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.