From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Do not leak pages when freeing
 userptr objects
Date: Mon, 29 Sep 2014 15:22:50 +0200
Message-ID: <20140929132250.GQ4109@phenom.ffwll.local>
References: <1411740322-12537-1-git-send-email-tvrtko.ursulin@linux.intel.com>
 <20140926145551.GC9308@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by gabe.freedesktop.org (Postfix) with ESMTP id E07C789E3F
 for <Intel-gfx@lists.freedesktop.org>; Mon, 29 Sep 2014 06:22:52 -0700 (PDT)
Received: by mail-wg0-f43.google.com with SMTP id a1so1771579wgh.14
 for <Intel-gfx@lists.freedesktop.org>; Mon, 29 Sep 2014 06:22:52 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140926145551.GC9308@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, Intel-gfx@lists.freedesktop.org, Tvrtko Ursulin <tvrtko.ursulin@intel.com>, "Barbalho, Rafael" <rafael.barbalho@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Sep 26, 2014 at 03:55:51PM +0100, Chris Wilson wrote:
> On Fri, Sep 26, 2014 at 03:05:22PM +0100, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > 
> > sg_alloc_table_from_pages() can build us a table with coalesced ranges which
> > means we need to iterate over pages and not sg table entries when releasing
> > page references.
> > 
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: "Barbalho, Rafael" <rafael.barbalho@intel.com>
> 
> Oh that's fun. I blame Imre for the recent invention of for_each_sg_page()!
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: stable@vger.kernel.org

Again merged to dinf for vetting time, thanks for patch&review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch