From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v3 1/2] iopoll: Introduce memory-mapped IO polling macros Date: Tue, 30 Sep 2014 08:04:43 +0200 Message-ID: <20140930060442.GF29874@ulmo> References: <1411874849-343-1-git-send-email-mitchelh@codeaurora.org> <1411874849-343-2-git-send-email-mitchelh@codeaurora.org> <20140929083136.GG12506@ulmo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0149921722164149123==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Mitchel Humpherys Cc: Will Deacon , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Matt Wagantall , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: iommu@lists.linux-foundation.org --===============0149921722164149123== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lIrNkN/7tmsD/ALM" Content-Disposition: inline --lIrNkN/7tmsD/ALM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 29, 2014 at 09:47:34AM -0700, Mitchel Humpherys wrote: > On Mon, Sep 29 2014 at 01:31:37 AM, Thierry Reding wrote: > > On Sat, Sep 27, 2014 at 08:27:28PM -0700, Mitchel Humpherys wrote: > >> From: Matt Wagantall > >>=20 > >> It is sometimes necessary to poll a memory-mapped register until its > >> value satisfies some condition. Introduce a family of convenience macr= os > >> that do this. Tight-loop and sleeping versions are provided with and > >> without timeouts. > >>=20 > >> Cc: Thierry Reding > >> Cc: Will Deacon > >> Signed-off-by: Matt Wagantall > >> Signed-off-by: Mitchel Humpherys > >> --- > >> include/linux/iopoll.h | 77 +++++++++++++++++++++++++++++++++++++++++= +++++++++ > >> 1 file changed, 77 insertions(+) > >> create mode 100644 include/linux/iopoll.h > > > > It would be good to provide a changelog with each new version of the > > patch. As it is I now have v2 and v3 of this patch in my inbox and I > > have no idea what the differences are, so I'd need to download both > > and run them through interdiff to find out. >=20 > Yeah I put the changelog in the cover letter. There were no changes on > this patch, though I admit that wasn't entirely clear now re-reading the > cover letter text. I also didn't account for the fact that you probably > aren't reading the whole series since I only Cc'd you on this patch, not > the whole series. In any case, I probably shouldn't have re-sent the > whole series after one minor modification to one patch in the series. No worries, thanks for clarifying. Thierry --lIrNkN/7tmsD/ALM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUKkf5AAoJEN0jrNd/PrOhfGcP/jNwdsdaqV8Cuv+NjxR+1Vut l3YCUpXDW3Y6IyzjXQIdydjAa9zgO4FwKIq24x0vks/SSJQ3WsXJSZx9FmUY+b7Z 8VtslQEK1rr9k9oNKfVkVp7e3c/Y7RrTJvqWR4Pq3f3oF9QzuwXKUdJ/IsO+ZL8A oOQIqTqM5anW/szmdl2kUVtDLh1R9caPSdZCWANe6SKE+pI5MNj7IpOIkIzKv/og Hu8iLNqx9Wj58cERNqmAlNOUwA032kOsRRxFTioK/E/FykA2GByXY5zc77kFoNEd Mmla+RurGTb8B+lrlddbnAQ0wzRBEM8vXZVMKQ/ECPcjIMMshrVigXJJsUR9sZL+ LQL9R6b7xWBLU9cJwfcX73DZqJcvLQh8kRi+qvSbkgvPQ9gwXTFiJRh+bVfrNxTg vRHntoEBxpnoyYVasI6K30l091NuzoPO8OaWmyx5XhoGrS2u+7eau5vFmhmP3Q08 TFr8oKuB9fyMd4PfXvuLT3TUSGf0ptsR474DiSvh8nwq4Q7tW8BBBS3zIflfRM5J Yei/J5iVPHX6jwXPG8n5Hebw3hT5/wAScmGa7Vgqom11jS1Ej22cAawGn1hPCiyc EI2fPnpyTyVHAW0m/t93fcDWkZw54XM28lc3skhoZ3yrfVsrGvvbEIeaczhMmo/6 xE400mOCHNWxdrUTNg26 =EO0/ -----END PGP SIGNATURE----- --lIrNkN/7tmsD/ALM-- --===============0149921722164149123== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============0149921722164149123==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: thierry.reding@gmail.com (Thierry Reding) Date: Tue, 30 Sep 2014 08:04:43 +0200 Subject: [PATCH v3 1/2] iopoll: Introduce memory-mapped IO polling macros In-Reply-To: References: <1411874849-343-1-git-send-email-mitchelh@codeaurora.org> <1411874849-343-2-git-send-email-mitchelh@codeaurora.org> <20140929083136.GG12506@ulmo> Message-ID: <20140930060442.GF29874@ulmo> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Sep 29, 2014 at 09:47:34AM -0700, Mitchel Humpherys wrote: > On Mon, Sep 29 2014 at 01:31:37 AM, Thierry Reding wrote: > > On Sat, Sep 27, 2014 at 08:27:28PM -0700, Mitchel Humpherys wrote: > >> From: Matt Wagantall > >> > >> It is sometimes necessary to poll a memory-mapped register until its > >> value satisfies some condition. Introduce a family of convenience macros > >> that do this. Tight-loop and sleeping versions are provided with and > >> without timeouts. > >> > >> Cc: Thierry Reding > >> Cc: Will Deacon > >> Signed-off-by: Matt Wagantall > >> Signed-off-by: Mitchel Humpherys > >> --- > >> include/linux/iopoll.h | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++ > >> 1 file changed, 77 insertions(+) > >> create mode 100644 include/linux/iopoll.h > > > > It would be good to provide a changelog with each new version of the > > patch. As it is I now have v2 and v3 of this patch in my inbox and I > > have no idea what the differences are, so I'd need to download both > > and run them through interdiff to find out. > > Yeah I put the changelog in the cover letter. There were no changes on > this patch, though I admit that wasn't entirely clear now re-reading the > cover letter text. I also didn't account for the fact that you probably > aren't reading the whole series since I only Cc'd you on this patch, not > the whole series. In any case, I probably shouldn't have re-sent the > whole series after one minor modification to one patch in the series. No worries, thanks for clarifying. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: