From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 01/28] Neutralize make uninstall Date: Tue, 30 Sep 2014 14:09:35 +0200 Message-ID: <20140930120934.GC15029@aepfle.de> References: <1411658423-18877-1-git-send-email-olaf@aepfle.de> <1411658423-18877-2-git-send-email-olaf@aepfle.de> <1411998589.3801.20.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1411998589.3801.20.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Tim Deegan , Keir Fraser , Ian Jackson , Jan Beulich , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, Sep 29, Ian Campbell wrote: > On Thu, 2014-09-25 at 17:19 +0200, Olaf Hering wrote: > > The uninstall target does not know about the paths it removes because > > the toplevel Makefile does not include the required files. > > > > Remove all dangerous commands. > > Of these only "rm -f $(D)$(XEN_RUN_DIR)*" seems especially dangerous. > > The rest will remove things like /*.conf and /xendomains which is > bad/wrong but not usually catastrophic > > > There is no replacement. > > Yet? Will this be replaced by additions to the appropriate submake files > in the course of this series? No. Unless I miss something, make uninstall can not work today. At least for the toplevel Makefile. If you want I can add more uninstall parts to the tools Makefiles in a separate series. Either for 4.5 or later. Olaf