From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbaJAXkv (ORCPT ); Wed, 1 Oct 2014 19:40:51 -0400 Received: from mail-bn1bon0116.outbound.protection.outlook.com ([157.56.111.116]:39574 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751798AbaJAXks (ORCPT ); Wed, 1 Oct 2014 19:40:48 -0400 Date: Thu, 2 Oct 2014 07:40:32 +0800 From: Peter Chen To: Antoine Tenart CC: , , , , , , , , , , Subject: Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx Message-ID: <20141001234031.GA2757@peterchendt> References: <1411468088-5702-1-git-send-email-antoine.tenart@free-electrons.com> <1411468088-5702-8-git-send-email-antoine.tenart@free-electrons.com> <20140930001206.GA11657@peterchendt> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20140930001206.GA11657@peterchendt> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:CAL;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(51704005)(189002)(24454002)(199003)(10300001)(68736004)(104016003)(85306004)(57986006)(83506001)(92566001)(21056001)(110136001)(47776003)(20776003)(50466002)(15975445006)(31966008)(102836001)(99396003)(97736003)(6806004)(97756001)(76482002)(107046002)(84676001)(19580405001)(85852003)(19580395003)(120916001)(44976005)(54356999)(4396001)(46406003)(33716001)(15202345003)(50986999)(106466001)(86362001)(87936001)(46102003)(33656002)(76176999)(105606002)(95666004)(64706001)(92726001)(80022003)(23726002)(26826002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0301MB0636;H:tx30smr01.am.freescale.net;FPR:;MLV:ovrnspm;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Antispam: UriScan:;UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0636; X-Forefront-PRVS: 0351D213B3 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=Peter.Chen@freescale.com; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0666; X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 30, 2014 at 08:12:07AM +0800, Peter Chen wrote: > On Tue, Sep 23, 2014 at 12:28:03PM +0200, Antoine Tenart wrote: > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > > and DMA mask, to support USB2 ChipIdea controllers that don't need > > specific functions. > > > > Tested on the Marvell Berlin SoCs USB controllers. > > > > Signed-off-by: Antoine Tenart > > --- > > drivers/usb/chipidea/Makefile | 1 + > > drivers/usb/chipidea/ci_hdrc_usb2.c | 138 ++++++++++++++++++++++++++++++++++++ > > 2 files changed, 139 insertions(+) > > create mode 100644 drivers/usb/chipidea/ci_hdrc_usb2.c > > > > diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile > > index 2f099c7df7b5..1fc86a2ca22d 100644 > > --- a/drivers/usb/chipidea/Makefile > > +++ b/drivers/usb/chipidea/Makefile > > @@ -10,6 +10,7 @@ ci_hdrc-$(CONFIG_USB_OTG_FSM) += otg_fsm.o > > > > # Glue/Bridge layers go here > > > > +obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_usb2.o > > obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_msm.o > > obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_zevio.o > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c > > new file mode 100644 > > index 000000000000..6eae1de587f2 > > --- /dev/null > > +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c > > @@ -0,0 +1,138 @@ > > +/* > > + * Copyright (C) 2014 Marvell Technology Group Ltd. > > + * > > + * Antoine Tenart > > + * > > + * This file is licensed under the terms of the GNU General Public > > + * License version 2. This program is licensed "as is" without any > > + * warranty of any kind, whether express or implied. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "ci.h" > > + > > +struct ci_hdrc_usb2_priv { > > + struct platform_device *ci_pdev; > > + struct clk *clk; > > +}; > > + > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > + struct ci_hdrc_platform_data *ci_pdata) > > +{ > > + ci_pdata->phy = of_phy_get(dev->of_node, 0); > > + if (IS_ERR(ci_pdata->phy)) { > > + if (PTR_ERR(ci_pdata->phy) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + > > + /* PHY is optional */ > > + ci_pdata->phy = NULL; > > + } > > + > > + return 0; > > +} > > + > > +static struct ci_hdrc_platform_data ci_default_pdata = { > > + .capoffset = DEF_CAPOFFSET, > > + .flags = CI_HDRC_REQUIRE_TRANSCEIVER | > > + CI_HDRC_DISABLE_STREAMING, > > +}; > > + > > +static int ci_hdrc_usb2_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct ci_hdrc_usb2_priv *priv; > > + struct ci_hdrc_platform_data *ci_pdata = dev_get_platdata(&pdev->dev); > > + int ret; > > + > > + if (!ci_pdata) > > + ci_pdata = &ci_default_pdata; > > + > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + priv->clk = devm_clk_get(dev, NULL); > > + if (!IS_ERR(priv->clk)) { > > + ret = clk_prepare_enable(priv->clk); > > + if (ret) { > > + dev_err(dev, "failed to enable the clock: %d\n", ret); > > + return ret; > > + } > > + } > > + > > + if (dev->of_node) { > > + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); > > + if (ret) > > + goto clk_err; > > + } else { > > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > > + if (ret) > > + goto clk_err; > > + } > Hi Antoine, if you pay attention the discussion for this patch, you should know to do change for your next revision - Call below unconditionally: > > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > > + if (ret) > > + goto clk_err; -Do not need function ci_hdrc_usb2_dt_probe, we need to cover both dt and non-dt, but there is nothing we can to differentiate now, The phy handle should be moved to core driver, since your generic phy driver are still not accepted, I can't do it by myself. Either you or I can do it after your generic phy support series has been accepted. > > + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); - Others are ok - The sequence of patch sets: 1. The generic PHY support for chipidea idea 2. Move getting PHY from individual glue layer to core driver 3. The generic chipidea driver Peter > > + > > + ci_pdata->name = dev_name(&pdev->dev); > > + > > + priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource, > > + pdev->num_resources, ci_pdata); > > + if (IS_ERR(priv->ci_pdev)) { > > + ret = PTR_ERR(priv->ci_pdev); > > + if (ret != -EPROBE_DEFER) > > + dev_err(dev, > > + "failed to register ci_hdrc platform device: %d\n", > > + ret); > > + goto clk_err; > > + } > > + > > + platform_set_drvdata(pdev, priv); > > + > > + pm_runtime_no_callbacks(dev); > > + pm_runtime_enable(dev); > > + > > + return 0; > > + > > +clk_err: > > + if (!IS_ERR(priv->clk)) > > + clk_disable_unprepare(priv->clk); > > + return ret; > > +} > > + > > +static int ci_hdrc_usb2_remove(struct platform_device *pdev) > > +{ > > + struct ci_hdrc_usb2_priv *priv = platform_get_drvdata(pdev); > > + > > + pm_runtime_disable(&pdev->dev); > > + ci_hdrc_remove_device(priv->ci_pdev); > > + clk_disable_unprepare(priv->clk); > > + > > + return 0; > > +} > > + > > +static const struct of_device_id ci_hdrc_usb2_of_match[] = { > > + { .compatible = "chipidea,usb2" }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, ci_hdrc_usb2_of_match); > > + > > +static struct platform_driver ci_hdrc_usb2_driver = { > > + .probe = ci_hdrc_usb2_probe, > > + .remove = ci_hdrc_usb2_remove, > > + .driver = { > > + .name = "chipidea-usb2", > > + .owner = THIS_MODULE, > > + .of_match_table = of_match_ptr(ci_hdrc_usb2_of_match), > > + }, > > +}; > > +module_platform_driver(ci_hdrc_usb2_driver); > > + > > +MODULE_DESCRIPTION("ChipIdea HDRC USB2 binding for ci13xxx"); > > +MODULE_AUTHOR("Antoine Tenart "); > > +MODULE_LICENSE("GPL"); > > -- > > 1.9.1 > > > > -- > Best Regards, > Peter Chen > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx Date: Thu, 2 Oct 2014 07:40:32 +0800 Message-ID: <20141001234031.GA2757@peterchendt> References: <1411468088-5702-1-git-send-email-antoine.tenart@free-electrons.com> <1411468088-5702-8-git-send-email-antoine.tenart@free-electrons.com> <20140930001206.GA11657@peterchendt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20140930001206.GA11657@peterchendt> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Antoine Tenart Cc: sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Sep 30, 2014 at 08:12:07AM +0800, Peter Chen wrote: > On Tue, Sep 23, 2014 at 12:28:03PM +0200, Antoine Tenart wrote: > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > > and DMA mask, to support USB2 ChipIdea controllers that don't need > > specific functions. > > > > Tested on the Marvell Berlin SoCs USB controllers. > > > > Signed-off-by: Antoine Tenart > > --- > > drivers/usb/chipidea/Makefile | 1 + > > drivers/usb/chipidea/ci_hdrc_usb2.c | 138 ++++++++++++++++++++++++++++++++++++ > > 2 files changed, 139 insertions(+) > > create mode 100644 drivers/usb/chipidea/ci_hdrc_usb2.c > > > > diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile > > index 2f099c7df7b5..1fc86a2ca22d 100644 > > --- a/drivers/usb/chipidea/Makefile > > +++ b/drivers/usb/chipidea/Makefile > > @@ -10,6 +10,7 @@ ci_hdrc-$(CONFIG_USB_OTG_FSM) += otg_fsm.o > > > > # Glue/Bridge layers go here > > > > +obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_usb2.o > > obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_msm.o > > obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_zevio.o > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c > > new file mode 100644 > > index 000000000000..6eae1de587f2 > > --- /dev/null > > +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c > > @@ -0,0 +1,138 @@ > > +/* > > + * Copyright (C) 2014 Marvell Technology Group Ltd. > > + * > > + * Antoine Tenart > > + * > > + * This file is licensed under the terms of the GNU General Public > > + * License version 2. This program is licensed "as is" without any > > + * warranty of any kind, whether express or implied. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "ci.h" > > + > > +struct ci_hdrc_usb2_priv { > > + struct platform_device *ci_pdev; > > + struct clk *clk; > > +}; > > + > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > + struct ci_hdrc_platform_data *ci_pdata) > > +{ > > + ci_pdata->phy = of_phy_get(dev->of_node, 0); > > + if (IS_ERR(ci_pdata->phy)) { > > + if (PTR_ERR(ci_pdata->phy) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + > > + /* PHY is optional */ > > + ci_pdata->phy = NULL; > > + } > > + > > + return 0; > > +} > > + > > +static struct ci_hdrc_platform_data ci_default_pdata = { > > + .capoffset = DEF_CAPOFFSET, > > + .flags = CI_HDRC_REQUIRE_TRANSCEIVER | > > + CI_HDRC_DISABLE_STREAMING, > > +}; > > + > > +static int ci_hdrc_usb2_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct ci_hdrc_usb2_priv *priv; > > + struct ci_hdrc_platform_data *ci_pdata = dev_get_platdata(&pdev->dev); > > + int ret; > > + > > + if (!ci_pdata) > > + ci_pdata = &ci_default_pdata; > > + > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + priv->clk = devm_clk_get(dev, NULL); > > + if (!IS_ERR(priv->clk)) { > > + ret = clk_prepare_enable(priv->clk); > > + if (ret) { > > + dev_err(dev, "failed to enable the clock: %d\n", ret); > > + return ret; > > + } > > + } > > + > > + if (dev->of_node) { > > + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); > > + if (ret) > > + goto clk_err; > > + } else { > > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > > + if (ret) > > + goto clk_err; > > + } > Hi Antoine, if you pay attention the discussion for this patch, you should know to do change for your next revision - Call below unconditionally: > > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > > + if (ret) > > + goto clk_err; -Do not need function ci_hdrc_usb2_dt_probe, we need to cover both dt and non-dt, but there is nothing we can to differentiate now, The phy handle should be moved to core driver, since your generic phy driver are still not accepted, I can't do it by myself. Either you or I can do it after your generic phy support series has been accepted. > > + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); - Others are ok - The sequence of patch sets: 1. The generic PHY support for chipidea idea 2. Move getting PHY from individual glue layer to core driver 3. The generic chipidea driver Peter > > + > > + ci_pdata->name = dev_name(&pdev->dev); > > + > > + priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource, > > + pdev->num_resources, ci_pdata); > > + if (IS_ERR(priv->ci_pdev)) { > > + ret = PTR_ERR(priv->ci_pdev); > > + if (ret != -EPROBE_DEFER) > > + dev_err(dev, > > + "failed to register ci_hdrc platform device: %d\n", > > + ret); > > + goto clk_err; > > + } > > + > > + platform_set_drvdata(pdev, priv); > > + > > + pm_runtime_no_callbacks(dev); > > + pm_runtime_enable(dev); > > + > > + return 0; > > + > > +clk_err: > > + if (!IS_ERR(priv->clk)) > > + clk_disable_unprepare(priv->clk); > > + return ret; > > +} > > + > > +static int ci_hdrc_usb2_remove(struct platform_device *pdev) > > +{ > > + struct ci_hdrc_usb2_priv *priv = platform_get_drvdata(pdev); > > + > > + pm_runtime_disable(&pdev->dev); > > + ci_hdrc_remove_device(priv->ci_pdev); > > + clk_disable_unprepare(priv->clk); > > + > > + return 0; > > +} > > + > > +static const struct of_device_id ci_hdrc_usb2_of_match[] = { > > + { .compatible = "chipidea,usb2" }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, ci_hdrc_usb2_of_match); > > + > > +static struct platform_driver ci_hdrc_usb2_driver = { > > + .probe = ci_hdrc_usb2_probe, > > + .remove = ci_hdrc_usb2_remove, > > + .driver = { > > + .name = "chipidea-usb2", > > + .owner = THIS_MODULE, > > + .of_match_table = of_match_ptr(ci_hdrc_usb2_of_match), > > + }, > > +}; > > +module_platform_driver(ci_hdrc_usb2_driver); > > + > > +MODULE_DESCRIPTION("ChipIdea HDRC USB2 binding for ci13xxx"); > > +MODULE_AUTHOR("Antoine Tenart "); > > +MODULE_LICENSE("GPL"); > > -- > > 1.9.1 > > > > -- > Best Regards, > Peter Chen > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: peter.chen@freescale.com (Peter Chen) Date: Thu, 2 Oct 2014 07:40:32 +0800 Subject: [PATCH v6 07/12] usb: chipidea: add a usb2 driver for ci13xxx In-Reply-To: <20140930001206.GA11657@peterchendt> References: <1411468088-5702-1-git-send-email-antoine.tenart@free-electrons.com> <1411468088-5702-8-git-send-email-antoine.tenart@free-electrons.com> <20140930001206.GA11657@peterchendt> Message-ID: <20141001234031.GA2757@peterchendt> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Sep 30, 2014 at 08:12:07AM +0800, Peter Chen wrote: > On Tue, Sep 23, 2014 at 12:28:03PM +0200, Antoine Tenart wrote: > > Add a USB2 ChipIdea driver for ci13xxx, with optional PHY, clock > > and DMA mask, to support USB2 ChipIdea controllers that don't need > > specific functions. > > > > Tested on the Marvell Berlin SoCs USB controllers. > > > > Signed-off-by: Antoine Tenart > > --- > > drivers/usb/chipidea/Makefile | 1 + > > drivers/usb/chipidea/ci_hdrc_usb2.c | 138 ++++++++++++++++++++++++++++++++++++ > > 2 files changed, 139 insertions(+) > > create mode 100644 drivers/usb/chipidea/ci_hdrc_usb2.c > > > > diff --git a/drivers/usb/chipidea/Makefile b/drivers/usb/chipidea/Makefile > > index 2f099c7df7b5..1fc86a2ca22d 100644 > > --- a/drivers/usb/chipidea/Makefile > > +++ b/drivers/usb/chipidea/Makefile > > @@ -10,6 +10,7 @@ ci_hdrc-$(CONFIG_USB_OTG_FSM) += otg_fsm.o > > > > # Glue/Bridge layers go here > > > > +obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_usb2.o > > obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_msm.o > > obj-$(CONFIG_USB_CHIPIDEA) += ci_hdrc_zevio.o > > > > diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c > > new file mode 100644 > > index 000000000000..6eae1de587f2 > > --- /dev/null > > +++ b/drivers/usb/chipidea/ci_hdrc_usb2.c > > @@ -0,0 +1,138 @@ > > +/* > > + * Copyright (C) 2014 Marvell Technology Group Ltd. > > + * > > + * Antoine Tenart > > + * > > + * This file is licensed under the terms of the GNU General Public > > + * License version 2. This program is licensed "as is" without any > > + * warranty of any kind, whether express or implied. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "ci.h" > > + > > +struct ci_hdrc_usb2_priv { > > + struct platform_device *ci_pdev; > > + struct clk *clk; > > +}; > > + > > +static int ci_hdrc_usb2_dt_probe(struct device *dev, > > + struct ci_hdrc_platform_data *ci_pdata) > > +{ > > + ci_pdata->phy = of_phy_get(dev->of_node, 0); > > + if (IS_ERR(ci_pdata->phy)) { > > + if (PTR_ERR(ci_pdata->phy) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > + > > + /* PHY is optional */ > > + ci_pdata->phy = NULL; > > + } > > + > > + return 0; > > +} > > + > > +static struct ci_hdrc_platform_data ci_default_pdata = { > > + .capoffset = DEF_CAPOFFSET, > > + .flags = CI_HDRC_REQUIRE_TRANSCEIVER | > > + CI_HDRC_DISABLE_STREAMING, > > +}; > > + > > +static int ci_hdrc_usb2_probe(struct platform_device *pdev) > > +{ > > + struct device *dev = &pdev->dev; > > + struct ci_hdrc_usb2_priv *priv; > > + struct ci_hdrc_platform_data *ci_pdata = dev_get_platdata(&pdev->dev); > > + int ret; > > + > > + if (!ci_pdata) > > + ci_pdata = &ci_default_pdata; > > + > > + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + priv->clk = devm_clk_get(dev, NULL); > > + if (!IS_ERR(priv->clk)) { > > + ret = clk_prepare_enable(priv->clk); > > + if (ret) { > > + dev_err(dev, "failed to enable the clock: %d\n", ret); > > + return ret; > > + } > > + } > > + > > + if (dev->of_node) { > > + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); > > + if (ret) > > + goto clk_err; > > + } else { > > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > > + if (ret) > > + goto clk_err; > > + } > Hi Antoine, if you pay attention the discussion for this patch, you should know to do change for your next revision - Call below unconditionally: > > + ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > > + if (ret) > > + goto clk_err; -Do not need function ci_hdrc_usb2_dt_probe, we need to cover both dt and non-dt, but there is nothing we can to differentiate now, The phy handle should be moved to core driver, since your generic phy driver are still not accepted, I can't do it by myself. Either you or I can do it after your generic phy support series has been accepted. > > + ret = ci_hdrc_usb2_dt_probe(dev, ci_pdata); - Others are ok - The sequence of patch sets: 1. The generic PHY support for chipidea idea 2. Move getting PHY from individual glue layer to core driver 3. The generic chipidea driver Peter > > + > > + ci_pdata->name = dev_name(&pdev->dev); > > + > > + priv->ci_pdev = ci_hdrc_add_device(dev, pdev->resource, > > + pdev->num_resources, ci_pdata); > > + if (IS_ERR(priv->ci_pdev)) { > > + ret = PTR_ERR(priv->ci_pdev); > > + if (ret != -EPROBE_DEFER) > > + dev_err(dev, > > + "failed to register ci_hdrc platform device: %d\n", > > + ret); > > + goto clk_err; > > + } > > + > > + platform_set_drvdata(pdev, priv); > > + > > + pm_runtime_no_callbacks(dev); > > + pm_runtime_enable(dev); > > + > > + return 0; > > + > > +clk_err: > > + if (!IS_ERR(priv->clk)) > > + clk_disable_unprepare(priv->clk); > > + return ret; > > +} > > + > > +static int ci_hdrc_usb2_remove(struct platform_device *pdev) > > +{ > > + struct ci_hdrc_usb2_priv *priv = platform_get_drvdata(pdev); > > + > > + pm_runtime_disable(&pdev->dev); > > + ci_hdrc_remove_device(priv->ci_pdev); > > + clk_disable_unprepare(priv->clk); > > + > > + return 0; > > +} > > + > > +static const struct of_device_id ci_hdrc_usb2_of_match[] = { > > + { .compatible = "chipidea,usb2" }, > > + { } > > +}; > > +MODULE_DEVICE_TABLE(of, ci_hdrc_usb2_of_match); > > + > > +static struct platform_driver ci_hdrc_usb2_driver = { > > + .probe = ci_hdrc_usb2_probe, > > + .remove = ci_hdrc_usb2_remove, > > + .driver = { > > + .name = "chipidea-usb2", > > + .owner = THIS_MODULE, > > + .of_match_table = of_match_ptr(ci_hdrc_usb2_of_match), > > + }, > > +}; > > +module_platform_driver(ci_hdrc_usb2_driver); > > + > > +MODULE_DESCRIPTION("ChipIdea HDRC USB2 binding for ci13xxx"); > > +MODULE_AUTHOR("Antoine Tenart "); > > +MODULE_LICENSE("GPL"); > > -- > > 1.9.1 > > > > -- > Best Regards, > Peter Chen > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Peter Chen