All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Amber Thrall <amber.rose.thrall@gmail.com>
Cc: jarod@wilsonet.com, m.chehab@samsung.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/
Date: Thu, 2 Oct 2014 05:45:24 -0700	[thread overview]
Message-ID: <20141002124524.GA25203@kroah.com> (raw)
In-Reply-To: <1412224802-28431-1-git-send-email-amber.rose.thrall@gmail.com>

On Wed, Oct 01, 2014 at 09:40:02PM -0700, Amber Thrall wrote:
> Fixed various coding style issues, including strings over 80 characters long and many 
> deprecated printk's have been replaced with proper methods.

Only do one thing per patch, you are doing lots of different things
here, and as Dan pointed out, you broke the build.

greg k-h

  parent reply	other threads:[~2014-10-02 12:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02  4:40 [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/ Amber Thrall
2014-10-02  4:49 ` Ilia Mirkin
2014-10-02  6:20 ` Jeremiah Mahler
2014-10-02 12:45 ` Greg KH [this message]
2014-10-02 13:29 ` Mauro Carvalho Chehab
2014-10-02 16:45   ` Joe Perches
2014-10-02 23:58     ` Antti Palosaari
2014-10-03  1:41       ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2014-10-02  2:35 Amber Thrall
2014-10-02  2:46 ` Greg KH
2014-10-02  8:13 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141002124524.GA25203@kroah.com \
    --to=greg@kroah.com \
    --cc=amber.rose.thrall@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=jarod@wilsonet.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.