From mboxrd@z Thu Jan  1 00:00:00 1970
From: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Subject: Re: [PATCH 0/4] Fix build issues with
 CONFIG_RTE_BUILD_COMBINE_LIBS=y
Date: Thu, 2 Oct 2014 13:26:34 -0400
Message-ID: <20141002172634.GE4900@hmsreliant.think-freely.org>
References: <1412265386-26291-1-git-send-email-sergio.gonzalez.monroy@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <1412265386-26291-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On Thu, Oct 02, 2014 at 04:56:22PM +0100, Sergio Gonzalez Monroy wrote:
> When building DPDK with CONFIG_RTE_BUILD_COMBINE_LIBS=y, the result is not
> the expected behavior.
> 
>  - It does link the combine library using LD instead of CC which results
> in application linking errors. 
> 
>  - It creates both individual libraries and combine library, then linking
> applications against all of them.
> 
> This patch set aims to fix those issues.
> 
> The last patch 'cleanup', in my opinion, simplifies and removes duplication of
> rules.
> It is not required for fixing the issues mentioned above.
> 
> Sergio Gonzalez Monroy (4):
>   Link combined shared library using CC
>   Do not generate individual libs when configured with RTE_BUILD_COMBINE_LIBS=y
>   Link apps only against combined lib or individual libs, not both
>   Cleanup
> 
>  mk/rte.app.mk      | 13 +++++---
>  mk/rte.lib.mk      | 90 +++++++++++++-----------------------------------------
>  mk/rte.sharelib.mk | 47 ++++++++++++++--------------
>  3 files changed, 54 insertions(+), 96 deletions(-)
> 
> Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> -- 
> 1.9.3
> 
> 

Just out of curiosity, whats the impetus behind a single shared library here?
Is it just to ease application linking operations?  If so, it almost seems to me
that we should abandon the individual linking method and just use this as the
default output (and do simmilarly for the static linking build)

Neil