From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH] mini-os: enable compiler check for printk format types Date: Sun, 5 Oct 2014 21:30:18 +0200 Message-ID: <20141005193018.GP5718@type> References: <1407318240-1799-1-git-send-email-talex5@gmail.com> <20140807145509.GK3426@type.youpi.perso.aquilenet.fr> <20140808143207.GA18842@type.bordeaux.inria.fr> <1412326515.423.11.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XarVp-0000a4-Jz for xen-devel@lists.xenproject.org; Sun, 05 Oct 2014 19:30:33 +0000 Content-Disposition: inline In-Reply-To: <1412326515.423.11.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xenproject.org" , Thomas Leonard , Stefano Stabellini , David Scott , Anil Madhavapeddy List-Id: xen-devel@lists.xenproject.org Ian Campbell, le Fri 03 Oct 2014 09:55:15 +0100, a =E9crit : > On Fri, 2014-10-03 at 09:44 +0100, Thomas Leonard wrote: > > On 8 August 2014 15:32, Samuel Thibault = wrote: > > > Thomas Leonard, le Fri 08 Aug 2014 15:28:22 +0100, a =E9crit : > > >> On 7 August 2014 15:55, Samuel Thibault wrote: > > >> > Thomas Leonard, le Wed 06 Aug 2014 10:44:00 +0100, a =E9crit : > > >> [...] > > >> >> diff --git a/extras/mini-os/netfront.c b/extras/mini-os/netfront.c > > >> >> index 44c3995..6f335fe 100644 > > >> >> --- a/extras/mini-os/netfront.c > > >> >> +++ b/extras/mini-os/netfront.c > > >> >> @@ -327,8 +327,8 @@ struct netfront_dev *init_netfront(char *_nod= ename, void (*thenetif_rx)(unsigned > > >> >> dev->fd =3D -1; > > >> >> #endif > > >> >> > > >> >> - printk("net TX ring size %d\n", NET_TX_RING_SIZE); > > >> >> - printk("net RX ring size %d\n", NET_RX_RING_SIZE); > > >> >> + printk("net TX ring size %llu\n", (unsigned long long) NET_T= X_RING_SIZE); > > >> >> + printk("net RX ring size %llu\n", (unsigned long long) NET_R= X_RING_SIZE); > > >> > > > >> > lib/printf.c does not actually support %ll yet, it uses %L instead. > > >> > > >> Actually, it looks like it does: > > >> > > >> if (qualifier =3D=3D 'l' && *fmt =3D=3D 'l') { > > >> qualifier =3D 'L'; > > >> ++fmt; > > >> } > > > > > > Oh, I missed this part of the code, thanks. For this exerpt of code, > > > long long is way too much, but for things like disk offsets and such, > > > it'd be preferrable to go for long long. > > = > > I see this patch never go applied. To be clear: the above comment was > > just for information. I agree with using %lu in the patch (as the > > latest version of the patch does). > > = > > So, I think this is ready to be applied: > > = > > http://lists.xenproject.org/archives/html/xen-devel/2014-08/msg00998.ht= ml > = > Samuel, are you ok with the patch after those clarifications? Yes. Reviewing it just kept being behind loads of stuff in my TODO list :/ Samuel