From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755639AbaJHKhE (ORCPT ); Wed, 8 Oct 2014 06:37:04 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:59469 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932077AbaJHKhB (ORCPT ); Wed, 8 Oct 2014 06:37:01 -0400 Date: Wed, 8 Oct 2014 11:36:58 +0100 From: Matt Fleming To: Peter Zijlstra Cc: Ingo Molnar , Jiri Olsa , Arnaldo Carvalho de Melo , Thomas Gleixner , linux-kernel@vger.kernel.org, "H. Peter Anvin" , Matt Fleming , Arnaldo Carvalho de Melo Subject: Re: [PATCH 08/11] perf/x86/intel: Add Intel Cache QoS Monitoring support Message-ID: <20141008103658.GP14343@console-pimps.org> References: <1411567455-31264-1-git-send-email-matt@console-pimps.org> <1411567455-31264-9-git-send-email-matt@console-pimps.org> <20141007194310.GC4750@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141007194310.GC4750@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 07 Oct, at 09:43:10PM, Peter Zijlstra wrote: > On Wed, Sep 24, 2014 at 03:04:12PM +0100, Matt Fleming wrote: > > +/* > > + * Determine if @a and @b measure the same set of tasks. > > + */ > > +static bool __match_event(struct perf_event *a, struct perf_event *b) > > +{ > > + if ((a->attach_state & PERF_ATTACH_TASK) != > > + (b->attach_state & PERF_ATTACH_TASK)) > > + return false; > > + > > + /* not task */ > > + > > + return true; /* if not task, we're machine wide */ > > +} > > You cut too much out there. That first test checks weather the two > events are of the same type; ie. both tasks or both cpu. After that you > still need to verify that they are indeed the same target. This gets fixed in PATCH 10 where we actually implement monitoring of task events. At this point in the series, we'll return -EINVAL from intel_cqm_event_init() for anything other than a cpu event. -- Matt Fleming, Intel Open Source Technology Center